Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services
SDK Breaking changes
This update includes multiple breaking changes to the SDK. These updates improve the SDK's usability, consistency.
Client type name
The API client type is renamed to
Client
for consistency, and remove stutter between package and client type name. Using Amazon S3 API client as an example, thes3.S3
type is renamed tos3.Client
.New API operation response type
API operations'
Request.Send
method now returns a Response type for the specific operation. The Response type wraps the operation's Output parameter, and includes a method for the response's metadata such as RequestID. The Output type is an anonymous embedded field within the Output type. If your application was passing the Output value around you'll need to extract it directly, or pass the Response type instead.New API operation paginator utility
This change removes the
Paginate
method from API operation Request types, (e.g. ListObjectsRequest). A new Paginator constructor is added that can be used to page these operations. To update your application to use the new pattern, wherePaginate
was being called, replace this with the Paginator type's constructor. The usage of the returned Paginator type is unchanged.Is updated to to use the Paginator constructor instead of Paginate method.
Other changes
ServiceID
.endpoints
package's service identifier constants. These values were unstable. Each API client package contains anEndpointsID
constant that can be used for service specific endpoint lookup.EndpointsID
(akaenpdointPrefix
). Searching for API endpoints in theendpoints
package should use the API client package's,EndpointsID
.SDK Enhancements
Update CI tests to ensure all codegen changes are accounted for in PR (Update CI tests to ensure all codegen changes are accounted for in PR #183)
Updates the CI tests to ensure that any code generation changes are accounted for in the PR, and that there were no mistaken changes made without also running code generation. This change should also help ensure that code generation order is stable, and there are no ordering issues with the SDK's codegen.
Related Update Travis tests to ensure all codegen changes are accounted for in PR aws-sdk-go#1966
service/dynamodb/expression
: Fix Builder with KeyCondition example (service/dynamodb/expression: Fix Builder with KeyCondition example #306)aws/defaults
: Fix UserAgent execution environment key (aws/defaults: Fix UserAgent execution environment key #307)private/model/api
: Improve SDK API reference doc generation (private/model/api: Improve SDK API reference doc generation #309)