aws: Fix BuildableHTTPClient datarace bug #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Mar 16, 2020
Fixes a broken unit test missed when implementing aws#487.
jasdel
force-pushed
the
fixup/BrokenTests
branch
from
c3eae86
to
57cc328
Compare
jasdel
force-pushed
the
fixup/BrokenTests
branch
from
21dd225
to
5011d98
Compare
jasdel
changed the title
skmcgrail
approved these changes
Mar 17, 2020
skotambkar
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the aws.BuildableHTTPClient's copy behavior to not encounter dataraces when being used concurrently.
Also fixes a broken unit test missed when implementing #487.