Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Regenerate APIs #821

Merged
merged 1 commit into from Oct 15, 2020
Merged

codegen: Regenerate APIs #821

merged 1 commit into from Oct 15, 2020

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Oct 14, 2020

Regenerates SDK API clients based on codegen change aws/smithy-go#216

JordonPhillips
JordonPhillips reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though you should probably rebase and re-run after the dependant PR is merged. There have been other doc fixes introduced

@jasdel jasdel mentioned this pull request Oct 15, 2020
Closed
@jasdel jasdel merged commit 62dfb2d into aws:master Oct 15, 2020
@jasdel jasdel deleted the regenAPIs branch October 15, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skmcgrail skmcgrail skmcgrail approved these changes

@skotambkar skotambkar Awaiting requested review from skotambkar

@JordonPhillips JordonPhillips Awaiting requested review from JordonPhillips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasdel @skmcgrail @JordonPhillips