aws: Fix Pagination handling of empty string NextToken #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the SDK's handling of a Pagination NextToken's value being an empty string compared to a nil value. The SDK was expecting NextToken's to always be unset (nil) and treating any non-nil value as a valid value. This was not the case in MediaLive's List APIs. As those APIs return a empty string value instead of null or not setting the field at all. This issue exists in both the v1 and v2 SDKs. Fix aws#84
Closed
xibz
suggested changes
Jan 15, 2018
| }{ | ||
| {aws.String("FirstValue"), aws.String("InitalToken"), aws.String("FirstToken")}, | ||
| {aws.String("SecondValue"), aws.String("FirstToken"), aws.String("SecondToken")}, | ||
| {aws.String("ThirdValue"), aws.String("SecondToken"), nil}, |
There was a problem hiding this comment.
Do we not have a test to test for ""?
There was a problem hiding this comment.
Yeah, TestPagination_Standalone is that testcase. The SDK already had this testcase but the way it worked prevented the bug from manifesting.
| } | ||
|
|
||
| tokenAdded = true |
There was a problem hiding this comment.
if they are bunch of empy strings, wouldn't tokenAdded not be set to true? Meaning this would never return the tokens
There was a problem hiding this comment.
tokenAdded is present if a valid token is added. The tokens slice is a sparse array. Its index directly correspond to indexes in another slice.
If all of the values at the outTokens paths are empty strings there will be no valid tokens in the tokens slice. In that case returning nil would be the correct action. If there is at least one valid value in outTokens paths the tokenAdded will be set to true.
xibz
approved these changes
Jan 15, 2018
Merged
jasdel
added a commit
that referenced
this pull request
Jan 15, 2018
Release v2.0.0-preview.2 (2018-01-15) === ### Services * Synced the V2 SDK with latests AWS service API definitions. ### SDK Bugs * `service/s3/s3manager`: Fix Upload Manger's UploadInput fields ([#89](#89)) * Fixes [#88](#88) * `aws`: Fix Pagination handling of empty string NextToken ([#94](#94)) * Fixes [#84](#84)
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Jan 15, 2018
Fixes the SDK's handling of a Pagination NextToken's value being an empty string compared to a nil value. The SDK was expecting NextToken's to always be unset (nil) and treating any non-nil value as a valid value. This was not the case in MediaLive's List APIs. As those APIs return a empty string value instead of null or not setting the field at all. V1 SDK port of aws/aws-sdk-go-v2#94
jasdel
added a commit
to aws/aws-sdk-go
that referenced
this pull request
Jan 26, 2018
Fixes the SDK's handling of a Pagination NextToken's value being an empty string compared to a nil value. The SDK was expecting NextToken's to always be unset (nil) and treating any non-nil value as a valid value. This was not the case in MediaLive's List APIs. As those APIs return a empty string value instead of null or not setting the field at all. V1 SDK port of aws/aws-sdk-go-v2#94
xibz
pushed a commit
to xibz/aws-sdk-go
that referenced
this pull request
Feb 15, 2018
) Fixes the SDK's handling of a Pagination NextToken's value being an empty string compared to a nil value. The SDK was expecting NextToken's to always be unset (nil) and treating any non-nil value as a valid value. This was not the case in MediaLive's List APIs. As those APIs return a empty string value instead of null or not setting the field at all. V1 SDK port of aws/aws-sdk-go-v2#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK's handling of a Pagination NextToken's value being an
empty string compared to a nil value. The SDK was expecting NextToken's
to always be unset (nil) and treating any non-nil value as a valid
value. This was not the case in MediaLive's List APIs. As those APIs
return a empty string value instead of null or not setting the field at
all.
This issue exists in both the v1 and v2 SDKs.
Fix #84