Skip to content

Commit

Permalink
Breaking change to fix JSONValue usage for CloudWatch Evidently. (#4415)
Browse files Browse the repository at this point in the history
Introduces a breaking change for following parameters from a JSONValue to string type, because the SDKs JSONValue is not compatible with the service's request and response shapes.

EvaluateFeatureInput.EvaluationContext
EvaluateFeatureOutput.Details
EvaluationRequest.EvaluationContext
EvaluationResult.Details
Event.Data
ExperimentReport.Content
MetricDefinition.EventPattern
MetricDefinitionConfig.EventPattern
  • Loading branch information
skmcgrail committed May 26, 2022
1 parent 6891065 commit 085b96f
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 74 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,12 @@
### SDK Enhancements

### SDK Bugs
* `service/cloudwatchevidently`: Introduces a breaking change for following parameters from a JSONValue to string type, because the SDKs JSONValue is not compatible with the service's request and response shapes.
* `EvaluateFeatureInput.EvaluationContext`
* `EvaluateFeatureOutput.Details`
* `EvaluationRequest.EvaluationContext`
* `EvaluationResult.Details`
* `Event.Data`
* `ExperimentReport.Content`
* `MetricDefinition.EventPattern`
* `MetricDefinitionConfig.EventPattern`
50 changes: 0 additions & 50 deletions private/model/api/legacy_jsonvalue.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,56 +32,6 @@ var legacyJSONValueShapes = map[string]map[string]legacyJSONValues{
},
},
},
"cloudwatchevidently": map[string]legacyJSONValues{
"EvaluateFeatureRequest": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"evaluationContext": struct{}{},
},
},
"EvaluateFeatureResponse": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"details": struct{}{},
},
},
"EvaluationRequest": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"evaluationContext": struct{}{},
},
},
"EvaluationResult": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"details": struct{}{},
},
},
"Event": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"data": struct{}{},
},
},
"ExperimentReport": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"content": struct{}{},
},
},
"MetricDefinition": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"eventPattern": struct{}{},
},
},
"MetricDefinitionConfig": legacyJSONValues{
Type: "structure",
StructMembers: map[string]struct{}{
"eventPattern": struct{}{},
},
},
},
"cloudwatchrum": map[string]legacyJSONValues{
"RumEvent": legacyJSONValues{
Type: "structure",
Expand Down
48 changes: 24 additions & 24 deletions service/cloudwatchevidently/api.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 085b96f

Please sign in to comment.