Skip to content

Commit

Permalink
service/s3/s3manager: Clarify S3 Upload manager Concurrency config (#…
Browse files Browse the repository at this point in the history
…1521)

Clarifies the S3 Upload Managers concurrency configuration is per call
to Upload, not shared across the instance of the Upload manager.

Fix #1458
  • Loading branch information
jasdel committed Sep 12, 2017
1 parent 2bbeb39 commit 971ef06
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions service/s3/s3manager/upload.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,11 @@ type Uploader struct {
// if this value is set to zero, the DefaultUploadPartSize value will be used.
PartSize int64

// The number of goroutines to spin up in parallel when sending parts.
// If this is set to zero, the DefaultUploadConcurrency value will be used.
// The number of goroutines to spin up in parallel per call to Upload when
// sending parts. If this is set to zero, the DefaultUploadConcurrency value
// will be used.
//
// The concurrency pool is not shared between calls to Upload.
Concurrency int

// Setting this value to true will cause the SDK to avoid calling
Expand Down

0 comments on commit 971ef06

Please sign in to comment.