Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/credentials: #1308 broke the Shared Credentials provider with session.New #1313

Closed
jasdel opened this issue Jun 1, 2017 · 0 comments
Closed

aws/credentials: #1308 broke the Shared Credentials provider with session.New #1313

jasdel opened this issue Jun 1, 2017 · 0 comments
Assignees
@jasdel
Labels
bug This issue is a bug.

Comments

@jasdel
Copy link
Contributor

jasdel commented Jun 1, 2017

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

5f43689228d059f9c064a48f6344090d3027c28a

Version of Go (go version)?

Go 1.8

What issue did you see?

session.New no longer gets credentials from the shared credentials file.

Steps to reproduce

Get an error trying to access EC2 metadata service with the following.

sess := session.New()
creds, err := sess.Config.Credentials.Get()
@jasdel jasdel added the bug This issue is a bug. label Jun 1, 2017
@jasdel jasdel self-assigned this Jun 1, 2017
@jasdel jasdel mentioned this issue Jun 1, 2017
Merged
jasdel added a commit that referenced this issue Jun 1, 2017
@jasdel
aws/credentials: Fix shared credential providers filename (#1312)
a6b7ec5 
In #1308 the filename was being retrieved with the SharedConfigFilename
utility function not SharedCredentialsFilename function.

This bug caused the session.New with the SharedCredentials file to break.

Fix #1313
@jasdel jasdel mentioned this issue Jun 1, 2017
Merged
jasdel added a commit that referenced this issue Jun 2, 2017
@jasdel
aws/credentials: Add tests for default shared credential filename (#1316
cacff17 
)

Adds tests for SharedCredentialProvider ensuring the correct default shared credential file is used if none is provided.

Related #1308 #1312 #1313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasdel jasdel

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasdel