SDK is unusable with dep and case insensitive filesystem

[ash2k]

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

1.40.49

Version of Go (go version)?

1.9

What issue did you see?

I'm on Mac with a case insensitive filesystem and I cannot use dep tool to add/update aws-sdk-go dependency because of the Greengrass and greengrass directories.

➜  https---github.com-aws-aws--sdk--go git:(ac95a675) ✗ git status
HEAD detached at ac95a675
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   models/apis/greengrass/2017-06-07/api-2.json
	modified:   models/apis/greengrass/2017-06-07/docs-2.json

no changes added to commit (use "git add" and/or "git commit -a")
➜  https---github.com-aws-aws--sdk--go git:(ac95a675) ✗ git checkout --
➜  https---github.com-aws-aws--sdk--go git:(ac95a675) ✗ rm models/apis/greengrass/2017-06-07/api-2.json models/apis/greengrass/2017-06-07/docs-2.json
➜  https---github.com-aws-aws--sdk--go git:(ac95a675) ✗ git status
HEAD detached at ac95a675
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	deleted:    models/apis/Greengrass/2017-06-07/api-2.json
	deleted:    models/apis/Greengrass/2017-06-07/docs-2.json
	deleted:    models/apis/greengrass/2017-06-07/api-2.json
	deleted:    models/apis/greengrass/2017-06-07/docs-2.json

no changes added to commit (use "git add" and/or "git commit -a")
➜  https---github.com-aws-aws--sdk--go git:(ac95a675) ✗ git reset --hard
HEAD is now at ac95a675 Merge pull request #1538 from aws/release
➜  https---github.com-aws-aws--sdk--go git:(ac95a675) ✗ git status
HEAD detached at ac95a675
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   models/apis/Greengrass/2017-06-07/api-2.json
	modified:   models/apis/Greengrass/2017-06-07/docs-2.json

no changes added to commit (use "git add" and/or "git commit -a")

Steps to reproduce

Try to setup a project with dep and aws-sdk-go. Sorry, the project where I'm having this issue is not opensource.

If you have have an runnable example, please include it.

[lokesh-shekar]

#1539 fix /models/apis/Greengrass dep case sensitivity

[ilovezfs]

Just hit this in Homebrew too in Homebrew/homebrew-core#18363.

[jasdel]

Thanks for posting this issue. Reviewing the change in the PR and repo it seems only the model folders Greengrass item is at fault. I'll investigate this more and correct this issue. It looks like the greengrass folder had it's casing changed some how. Will update this GitHub issue when a fix is available. Temporary fix will be correcting the casing locally, but need to fix this upstream as well so it doesn't happen again.

[jasdel]

I've posted a PR #1541 that should correct the issue. We'll need to make some internally changes to how the release is generated too. As apart of these changes I think when the SDK's models are generated it should fail if two models target the same service's package. This is what occurred here both, Greengrass and greengrass were used to generate the greengrass service client. With the latter stomping over the former.

[jasdel]

Thanks again for pointing this issue out and alerting us to it. The PR has corrected the issue, and will be apart of our next tagged release.