Insufficient documentation of NewStaticCredentials

[tcurdt]

Version of AWS SDK for Go?

github.com/aws/aws-sdk-go v1.29.3

Version of Go (go version)?

go version go1.13.8 darwin/amd64

What issue did you see?

I am trying to authenticate but cannot use env variables or files to pass the credentials. This should be doable using NewStaticCredentials(id, secret, token string) *Credentials but there is no explanation at all what the token is or where to obtain it from.

Someone else asked the same thing on StackOverflow and this was raise before on another issue.

Please improve the documentation clarifying that token can be an empty string.
Even better yet - provide a method signature without a token.

[diehlaws]

Hi @tcurdt, thanks for your feedback on this matter. The token parameter for this function is used when providing temporary security credentials to your service client that can be retrieved from STS (e.g. via a GetSessionToken request).

While this is mentioned in the SDK's developer guide, mentioning what this token is in the SDK's API Reference and clarifying that it is not required for all static credentials would certainly help reduce confusion in this matter. We will work on updating this soon.

[tcurdt]

Much appreciated, @diehlaws. Thanks!