Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: SDK code generation of eventstream exception methods are not stable #3664

Closed
jasdel opened this issue Nov 30, 2020 · 1 comment · Fixed by #3681
Closed

codegen: SDK code generation of eventstream exception methods are not stable #3664

jasdel opened this issue Nov 30, 2020 · 1 comment · Fixed by #3681
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS.

Comments

@jasdel
Copy link
Contributor

jasdel commented Nov 30, 2020 •
edited
Loading

The SDK's code generation of evenstream exception shape methods for association with the set of events for a stream are not generated in stable order. Periodically this is causing failed CI builds.

https://travis-ci.com/github/aws/aws-sdk-go/jobs/451137684#L13400-L13411

-// The InternalFailureException is and event in the MedicalTranscriptResultStream group of events.
-func (s *InternalFailureException) eventMedicalTranscriptResultStream() {}
-
 // The InternalFailureException is and event in the TranscriptResultStream group of events.
 func (s *InternalFailureException) eventTranscriptResultStream() {}

+// The InternalFailureException is and event in the MedicalTranscriptResultStream group of events.
+func (s *InternalFailureException) eventMedicalTranscriptResultStream() {}
+
 // UnmarshalEvent unmarshals the EventStream Message into the InternalFailureException value.
 // This method is only used internally within the SDK's EventStream handling.
 func (s *InternalFailureException) UnmarshalEvent(

Looks like the SDK's Shape.EventsFor slice of EventStream may not be stable order.
@jasdel jasdel added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 30, 2020
@KaibaLopez KaibaLopez added contribution/core This is a PR that came from AWS. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 8, 2020
jasdel added a commit to jasdel/aws-sdk-go that referenced this issue Dec 8, 2020
@jasdel
codegen: Ensure event stream events are in sorted order
77fb636 
Updates the SDK's code generation for event stream member event for
methods to be sorted order. Ensures load order doesn't impact code
generation output.

Fixes aws#3664
@jasdel jasdel mentioned this issue Dec 8, 2020
Merged
jasdel added a commit that referenced this issue Dec 10, 2020
@jasdel
codegen: Ensure event stream events are in sorted order (#3681)
ca8954d 
Updates the SDK's code generation for event stream member event for
methods to be sorted order. Ensures load order doesn't impact code
generation output.

Fixes #3664
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codegen: Ensure event stream events are in sorted order jasdel/aws-sdk-go
2 participants
@jasdel @KaibaLopez