leaking file descriptors in s3 GetObject

[bctsui]

This is how I can reproduce:

1. Set max file descriptors to N (eg. ulimit -n N).
2. Make N calls to S3.GetObject() for N different keys that exist.
3. Make the (N+1)th call to S3.GetObject() for a different object and an error about too many open files will appear.

Are we supposed to free up resources or reuse connections manually? I don't see it anywhere in the docs.

[jasdel]

Thanks for contacting us @bctsui. Yes you'll need to close the GetObjectOutput.Body io.ReadCloser when your done with it. This body is basically the same as a http.Response.Body and needs to be closed after ever response. Thanks about pointing out the documentation could be better. Tagging this so we can add documentations around this.

[jasdel]

Hi @bctsui I've updated our wiki documentation to include the need to close the body on operation responses with a Body or io.ReadCloser fields.

https://github.com/aws/aws-sdk-go/wiki/making-requests#handling-operation-response-body