aws/request: Fix HTTP Request Body race condition. #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the possible race conditions where the SDK's request body could be mutated by the HTTP request directly. This could occur because the SDK did not consistently protect the SDK's request#Request.Body parameter from the http#Request.Body. This inconsistency prevented the SDK from protecting against race conditions when HTTP Client's Transport would still be reading on the http#Request.body and the SDK would be attempting to retry the API operation. During a API operation retry the request#Request.Body needs to be rewound for then next retry of the HTTP request. This is protected now by creating a strong separation between the request#Request.Body and http#Request.Body. A per request wrapper is created for each HTTP request attempt that is safe to use concurrently. Fix aws#868, aws#869, aws#871
|
Reviewing this PR in place of PR #871. |
This was referenced Oct 6, 2016
jasdel
added a commit
that referenced
this pull request
Oct 6, 2016
Service Model Updates --- `service/cognitoidentityprovider`: Update Amazon Cognito Identity Provider service model `service/devicefarm`: Update AWS Device Farm documentation `service/opsworks`: Update AWS OpsWorks service model `service/s3`: Update Amazon Simple Storage Service model `service/waf`: Update AWS WAF service model SDK Bug Fixes --- `aws/request`: Fix HTTP Request Body race condition #874 SDK Feature Updates --- `aws/ec2metadata`: Add support for EC2 User Data #872 `aws/signer/v4`: Remove logic determining if request needs to be resigned #876
Merged
jasdel
added a commit
that referenced
this pull request
Oct 6, 2016
Service Model Updates --- `service/cognitoidentityprovider`: Update Amazon Cognito Identity Provider service model `service/devicefarm`: Update AWS Device Farm documentation `service/opsworks`: Update AWS OpsWorks service model `service/s3`: Update Amazon Simple Storage Service model `service/waf`: Update AWS WAF service model SDK Bug Fixes --- `aws/request`: Fix HTTP Request Body race condition #874 SDK Feature Updates --- `aws/ec2metadata`: Add support for EC2 User Data #872 `aws/signer/v4`: Remove logic determining if request needs to be resigned #876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the possible race conditions where the SDK's request body could be
mutated by the HTTP request directly. This could occur because the SDK did
not consistently protect the SDK's request#Request.Body parameter from the
http#Request.Body. This inconsistency prevented the SDK from protecting
against race conditions when HTTP Client's Transport would still be reading
on the http#Request.body and the SDK would be attempting to retry the
API operation.
During a API operation retry the request#Request.Body needs to be rewound
for then next retry of the HTTP request. This is protected now by creating
a strong separation between the request#Request.Body and http#Request.Body.
A per request wrapper is created for each HTTP request attempt that is safe
to use concurrently.
Fix #868, #869, #871