Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/request: Fix HTTP Request Body race condition. #874

Merged
merged 3 commits into from
Oct 6, 2016
Merged

aws/request: Fix HTTP Request Body race condition. #874

merged 3 commits into from
Oct 6, 2016

Commits on Oct 5, 2016

  1. aws/request: Fix HTTP Request Body race condition. 

    Fixes the possible race conditions where the SDK's request body could be
mutated by the HTTP request directly. This could occur because the SDK did
not consistently protect the SDK's request#Request.Body parameter from the
http#Request.Body. This inconsistency prevented the SDK from protecting
against race conditions when HTTP Client's Transport would still be reading
on the http#Request.body and the SDK would be attempting to retry the
API operation.

During a API operation retry the request#Request.Body needs to be rewound
for then next retry of the HTTP request. This is protected now by creating
a strong separation between the request#Request.Body and http#Request.Body.
A per request wrapper is created for each HTTP request attempt that is safe
to use concurrently.

Fix aws#868, aws#869, aws#871
    @jasdel
    jasdel committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    463f6c8 View commit details
    Browse the repository at this point in the history

  2. fix io.Seekxxx usage, not available until Go 1.7

    @jasdel
    jasdel committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    2bb7ea4 View commit details
    Browse the repository at this point in the history

  3. Actually fix the io.Seekxxx this time

    @jasdel
    jasdel committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    d419f5e View commit details
    Browse the repository at this point in the history