Operand Implementation Pull Request #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
reviewed
Jul 27, 2017
| type OperandBuilder interface { | ||
| BuildOperand(AliasList) (Expression, error) | ||
| ListOperand() (AliasList, error) | ||
| } |
There was a problem hiding this comment.
Suggest this being:
type OperandExpression struct {
OpType
Key string
Value *dynamodb.AttributeValue
}
type OperandBuilder interface {
BuildOperand() (OperandExpression, error)
}
xibz
suggested changes
Aug 1, 2017
|
|
||
| const ( | ||
| // EqualCond will represent the Equal Clause ConditionBuilder | ||
| EqualCond ConditionMode = iota + 1 |
There was a problem hiding this comment.
Why are we starting at 1 here?
|
|
||
| switch c.Mode { | ||
| case EqualCond: | ||
| ret.fmtExpr = "$c = $c" |
There was a problem hiding this comment.
Should probably add some comments to this function about what $ means
| name, value, children int | ||
| }{} | ||
|
|
||
| //index := [3]int{} |
| } | ||
|
|
||
| var alias string | ||
| switch expr.Expression[i+1] { |
There was a problem hiding this comment.
could this case ever happen i == len(expression)-1?
There was a problem hiding this comment.
I wonder if an AST would be better here as opposed a fmt string
| index.children++ | ||
| } | ||
| expr.Expression = expr.Expression[:i] + alias + expr.Expression[i+2:] | ||
| i += len(alias) |
There was a problem hiding this comment.
we should probably have a default case that returns an error saying case not supported
xibz
approved these changes
Aug 2, 2017
jasdel
pushed a commit
that referenced
this pull request
Aug 7, 2017
* Initial commit * write Base32Encoding test cases * Implement numeric encoding instead of Base32 * Minor changes to satisfy golinter * Implement unexported tree structure * write tests * Finish basic tests * Use sprintf style aliasing * Add BuildExpression method to ConditionBuilder * Make change based on inline PR * Add name to tests, comments for clarity, more index panic coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.