Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/client: adding 429, too many requests, to throttling error codes #1621

Merged
merged 1 commit into from Oct 31, 2017

Conversation

xibz
Copy link
Contributor

@xibz xibz commented Oct 31, 2017

No description provided.

@xibz xibz requested a review from jasdel October 31, 2017 19:27
@xibz xibz force-pushed the bug_dynamodbattribute branch 3 times, most recently from 9f2c191 to 757cdee Compare October 31, 2017 19:31
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding support Retry-After header, https://tools.ietf.org/html/rfc6585#section-4

@@ -1,5 +1,6 @@
### SDK Features

### SDK Enhancements
aws/client: Adding status code 429 to throttlable status codes in default retryer (#1621)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, should include the ` around the package.

@xibz xibz merged commit d5c4a72 into aws:master Oct 31, 2017
@awstools awstools mentioned this pull request Nov 1, 2017
@xibz xibz deleted the bug_dynamodbattribute branch March 8, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants