private/protocol: wrapping serialization errors #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a serialization error occurred during unmarshaling
jasdel
suggested changes
Sep 5, 2018
| r.Error = awserr.NewRequestFailure( | ||
| awserr.New("SerializationError", "failed decoding EC2 Query response", err), | ||
| r.HTTPResponse.StatusCode, | ||
| "", |
There was a problem hiding this comment.
Need to populate the RequestID field for these errors. This can be obtained from r.RequestID i think, but need to make sure. The r.RequestID should of been populated from the UnmarshalMeta handler list.
Aloha106
suggested changes
Sep 5, 2018
jasdel
approved these changes
Sep 6, 2018
Merged
usrenmae
pushed a commit
to usrenmae/aws-sdk-go
that referenced
this pull request
Sep 23, 2018
* serialization errors will now be wrapped as a request failure error if a serialization error occurred during unmarshaling * adding request ID to request failure errors
xibz
added a commit
to xibz/aws-sdk-go
that referenced
this pull request
Oct 15, 2018
* serialization errors will now be wrapped as a request failure error if a serialization error occurred during unmarshaling * adding request ID to request failure errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow serialization errors that were being returned during unmarshaling to be wrapped in a
awserr.RequestFailureinstead. This allows for custom retryers to get at the status code more easily.