aws/signer: Always sign a request with the current time. #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SDK's v4 request signer to always sign requests with the current time. For the first request attempt, the request's creation time was used in the request's signature. In edge cases this allowed the signature to expire before the request was sent if there was significant delay between creating the request and sending it, (e.g. rate limiting).
diehlaws
approved these changes
Dec 6, 2018
Merged
adamyanova
added a commit
to adamyanova/go_s3tests_old
that referenced
this pull request
Jan 9, 2019
…n the AWS Go SDK v1.16.2 introduced after commit aws/aws-sdk-go#2336 Signed-off-by: Antoaneta Damyanova <adamyanova@gmail.com>
adamyanova
added a commit
to adamyanova/go_s3tests
that referenced
this pull request
Jan 11, 2019
…n the AWS Go SDK v1.16.2 introduced after commit aws/aws-sdk-go#2336 It is for debug purposes. Also, keep in mind that after changing the handler in the abovementioned test, it stays changed for tests executed afterwords and the "Request time too skewed" error will keep propagating through them. Signed-off-by: Antoaneta Damyanova <adamyanova@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's v4 request signer to always sign requests with the
current time. For the first request attempt, the request's creation time
was used in the request's signature. In edge cases this allowed the
signature to expire before the request was sent if there was significant
delay between creating the request and sending it, (e.g. rate limiting).