service/s3/s3manager: Prefer using allocated slices from pool over allocating new ones. #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you for this contribution @mikhail-chebakov this is a nice optimization corner case you've found. I'll give this a look over and work on getting it merged in. |
agniutkarsh
approved these changes
Sep 18, 2020
jasdel
added
the
needs-review
…ing new ones if possible Problem: S3 uploader could allocate more memory than it is actually needed. Added unit test should showcase the problem
skmcgrail
force-pushed
the
prefer-using-allocated-slices-over-allocating-new-ones
branch
from
215d3c7
to
0a015e6
Compare
skmcgrail
approved these changes
Sep 22, 2020
skmcgrail
removed
the
needs-review
skmcgrail
changed the title
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Sep 23, 2020
=== ### Service Client Updates * `service/backup`: Updates service API and documentation * `service/ce`: Updates service API and documentation * `service/quicksight`: Updates service API and documentation * Added Sheet information to DescribeDashboard, DescribeTemplate and DescribeAnalysis API response. * `service/translate`: Updates service API and documentation ### SDK Enhancements * `service/s3/s3manager`: Prefer using allocated slices from pool over allocating new ones. ([#3534](#3534))
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Sep 23, 2020
Release v1.34.30 (2020-09-23) === ### Service Client Updates * `service/backup`: Updates service API and documentation * `service/ce`: Updates service API and documentation * `service/quicksight`: Updates service API and documentation * Added Sheet information to DescribeDashboard, DescribeTemplate and DescribeAnalysis API response. * `service/translate`: Updates service API and documentation ### SDK Enhancements * `service/s3/s3manager`: Prefer using allocated slices from pool over allocating new ones. ([#3534](#3534))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
S3 uploader could allocate more memory than it is actually needed.
Added unit test should showcase the problem
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.