Fixes ini file parsing for cases when Right Hand Value is missed in the last statement of the ini file #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is missed in the last statement of the ini file.
…is missed in the last statement of the ini file.
…is missed in the last statement of the ini file.
jasdel
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Thanks for taking the time to create this PR @Otanikotani. The change to allow empty equal at the end of the time be considered a none token looks good. We'll get this PR merged and and included in the next released once it is merged.
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Oct 21, 2020
=== ### Service Client Updates * `service/cloudfront`: Updates service API and documentation * CloudFront adds support for managing the public keys for signed URLs and signed cookies directly in CloudFront (it no longer requires the AWS root account). * `service/ec2`: Updates service API and documentation * instance-storage-info nvmeSupport added to DescribeInstanceTypes API * `service/globalaccelerator`: Updates service API and documentation * `service/glue`: Updates service API and documentation * AWS Glue crawlers now support incremental crawls for the Amazon Simple Storage Service (Amazon S3) data source. * `service/kendra`: Updates service API and documentation * This release adds custom data sources: a new data source type that gives you full control of the documents added, modified or deleted during a data source sync while providing run history metrics. * `service/organizations`: Updates service documentation * AWS Organizations renamed the 'master account' to 'management account'. ### SDK Bugs * `aws/credentials`: Fixed a race condition checking if credentials are expired. ([#3448](#3448)) * Fixes [#3524](#3524) * `internal/ini`: Fixes ini file parsing for cases when Right Hand Value is missed in the last statement of the ini file ([#3596](#3596)) * related to [#2800](#2800)
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Oct 21, 2020
Release v1.35.12 (2020-10-21) === ### Service Client Updates * `service/cloudfront`: Updates service API and documentation * CloudFront adds support for managing the public keys for signed URLs and signed cookies directly in CloudFront (it no longer requires the AWS root account). * `service/ec2`: Updates service API and documentation * instance-storage-info nvmeSupport added to DescribeInstanceTypes API * `service/globalaccelerator`: Updates service API and documentation * `service/glue`: Updates service API and documentation * AWS Glue crawlers now support incremental crawls for the Amazon Simple Storage Service (Amazon S3) data source. * `service/kendra`: Updates service API and documentation * This release adds custom data sources: a new data source type that gives you full control of the documents added, modified or deleted during a data source sync while providing run history metrics. * `service/organizations`: Updates service documentation * AWS Organizations renamed the 'master account' to 'management account'. ### SDK Bugs * `aws/credentials`: Fixed a race condition checking if credentials are expired. ([#3448](#3448)) * Fixes [#3524](#3524) * `internal/ini`: Fixes ini file parsing for cases when Right Hand Value is missed in the last statement of the ini file ([#3596](#3596)) * related to [#2800](#2800)
This was referenced Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a bugfix for the INI parser that fails to parse an INI file like:
Notice the absence of the empty line at the end of the file.
There was a previously closed bug addressing a similar issue - #2800, but the corner case when the right-hand value is missed in the last statement is still failing.
In my case, it was critical (granted adding a newline at the end of the file also fixes it) as I had a
~/.aws/configwritten as described in AWS Docs here: https://docs.aws.amazon.com/cli/latest/userguide/cli-usage-pagination.html :Please note, that in this case an
ASTKindSkipStatementstatement is not added in the resulting AST. If the desired behaviour would be to still have it - I can try to figure out how to add it.