private/protocol: Loosen endpoint validation to allow customer specify port number #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
changed the title
skotambkar
approved these changes
Jan 13, 2021
skmcgrail
approved these changes
Jan 13, 2021
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Jan 13, 2021
=== ### Service Client Updates * `service/frauddetector`: Updates service API and documentation * `service/personalize`: Updates service documentation ### SDK Enhancements * `private/protocol`: Loosen endpoint validation to allow customer specify port number ([#3730](#3730)) * Updates SDK's endpoint validation of the hostname to allow ports to be specified. * `service/s3/s3manager`: Add ETag field to UploadOutput ([#3733](#3733)) * Adds the ETag field to the Uploader's UploadOutput return value. * Fixes [#2764](#2764) * `aws`: Add `WithLowerCaseHeaderMaps` and `WithDisableRestProtocolURICleaning` to `aws.Config`. ([#3671](#3671)) ### SDK Bugs * `aws`: Fixed a case where `LowerCaseHeaderMaps` would not be merged when merging`aws.Config` types. ([#3671](#3671))
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Jan 13, 2021
Release v1.36.26 (2021-01-13) === ### Service Client Updates * `service/frauddetector`: Updates service API and documentation * `service/personalize`: Updates service documentation ### SDK Enhancements * `private/protocol`: Loosen endpoint validation to allow customer specify port number ([#3730](#3730)) * Updates SDK's endpoint validation of the hostname to allow ports to be specified. * `service/s3/s3manager`: Add ETag field to UploadOutput ([#3733](#3733)) * Adds the ETag field to the Uploader's UploadOutput return value. * Fixes [#2764](#2764) * `aws`: Add `WithLowerCaseHeaderMaps` and `WithDisableRestProtocolURICleaning` to `aws.Config`. ([#3671](#3671)) ### SDK Bugs * `aws`: Fixed a case where `LowerCaseHeaderMaps` would not be merged when merging`aws.Config` types. ([#3671](#3671))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Java SDK and AWS Python SDK allow customer to use endpoint with port number. So AWS Go SDK should allow this too