Close http.Response.Body in S3 CopyObject, UploadPartCopy and CompleteMultipartUpload operations. #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
suggested changes
Aug 4, 2021
There was a problem hiding this comment.
Thanks for creating this PR @ashtuchkin, and fixing the response body not being closed in case of 200 status code with error.
The change looks good, minor comment about using defer for body
jasdel
approved these changes
Aug 7, 2021
|
@jasdel When will this be merged? |
…nd CompleteMultipartUpload operations. Fixes aws#4037
|
Does this fix #3549? (Multi-part upload to S3 leaves open X-ray subsegment ) |
|
I think it should, but have no way to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4037. See that issue for more details.
Note, in case of read error we don't close the body because later Unmarshal hooks expect it to not be closed (they close it themselves). There's an existing test guarding that behavior.
Close error is ignored as it has no side effects and there's nothing we can do about it.