Fix lexv1 AlternativeIntentsSerializationError #4264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserialisation of the `X-Amz-Lex-Alternative-Intents` header fails because it
is a JSON array, but `aws.JSONValue` is a `map[string]interface{}`. Fix this by
treating `X-Amz-Lex-Alternative-Intents` as a base64 encoded string, which will
not be decoded and unmarshalled by the SDK. The caller of the SDK must manually
base64 decode and JSON unmarshal the field, in order to use the contents.
I'm guessing this applies here... |
ActiveContexts is also a JSON array.
|
Thanks for taking the time to create this PR @chrbsg. Since this PR modifies the SDK's API model/generated code we cannot take this Pr directly. But with that said, i created #4269. This new PR takes the idea of supressing the JSONValue traits for these API parameters. Taking a step further the PR also disables future support for JSONValue in the v1 SDK to prevent further issues. |
Merged
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Feb 16, 2022
=== ### Service Client Updates * `service/budgets`: Updates service API and documentation * Adds support for auto-adjusting budgets, a new budget method alongside fixed and planned. Auto-adjusting budgets introduces new metadata to configure a budget limit baseline using a historical lookback average or current period forecast. * `service/ce`: Updates service API * `service/ec2`: Updates service API and documentation * Documentation updates for EC2. * `service/glue`: Updates service API and documentation * Support for optimistic locking in UpdateTable * `service/ssm`: Updates service documentation * Assorted ticket fixes and updates for AWS Systems Manager. ### SDK Features * `codegen`: Updates the SDK's code generation to stop supporting new API modeled JSONValue parameters. The SDK's JSONValue type is only compatible with JSON documents with a top level JSON Object. JSON Lists, Strings, Scalars, are not compatible. This prevents JSON Value working with some APIs such as Amazon Lex Runtime Service's operations. * Related to [#4264](#4264) and [#4258](#4258) ### SDK Bugs * `service/lexruntimeservice`: Introduces a breaking change for following parameters from a JSONValue to string type, because the SDKs JSONValue is not compatible with JSON documents of lists. * PostContentInput.ActiveContexts * PutContentOutput.AlternativeIntents * PutContentOutput.ActiveContexts * PutSessionOutput.ActiveContexts * Fixes [#4258](#4258)
aws-sdk-go-automation
added a commit
that referenced
this pull request
Feb 16, 2022
Release v1.43.0 (2022-02-16) === ### Service Client Updates * `service/budgets`: Updates service API and documentation * Adds support for auto-adjusting budgets, a new budget method alongside fixed and planned. Auto-adjusting budgets introduces new metadata to configure a budget limit baseline using a historical lookback average or current period forecast. * `service/ce`: Updates service API * `service/ec2`: Updates service API and documentation * Documentation updates for EC2. * `service/glue`: Updates service API and documentation * Support for optimistic locking in UpdateTable * `service/ssm`: Updates service documentation * Assorted ticket fixes and updates for AWS Systems Manager. ### SDK Features * `codegen`: Updates the SDK's code generation to stop supporting new API modeled JSONValue parameters. The SDK's JSONValue type is only compatible with JSON documents with a top level JSON Object. JSON Lists, Strings, Scalars, are not compatible. This prevents JSON Value working with some APIs such as Amazon Lex Runtime Service's operations. * Related to [#4264](#4264) and [#4258](#4258) ### SDK Bugs * `service/lexruntimeservice`: Introduces a breaking change for following parameters from a JSONValue to string type, because the SDKs JSONValue is not compatible with JSON documents of lists. * PostContentInput.ActiveContexts * PutContentOutput.AlternativeIntents * PutContentOutput.ActiveContexts * PutSessionOutput.ActiveContexts * Fixes [#4258](#4258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserialisation of the
X-Amz-Lex-Alternative-Intentsheader fails because itis a JSON array, but
aws.JSONValueis amap[string]interface{}. Fix this bytreating
X-Amz-Lex-Alternative-Intentsas a base64 encoded string, which willnot be decoded and unmarshalled by the SDK. The caller of the SDK must manually
base64 decode and JSON unmarshal the field, in order to use the contents.
bug #4258