Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AmazonWebServiceRequest as base model #33

Closed
millems opened this issue Jul 3, 2017 · 0 comments · Fixed by #289
Closed

Remove AmazonWebServiceRequest as base model #33

millems opened this issue Jul 3, 2017 · 0 comments · Fixed by #289
Assignees
@dagnir
Labels
2.0 New feature-request A feature should be added or improved.

Comments

@millems
Copy link
Contributor

millems commented Jul 3, 2017

All model objects currently extend AmazonWebServiceRequest, which includes a large number of deprecated 1.11.x concepts. This base class should be removed or replaced to clean up the contents of our model objects.
@dagnir dagnir self-assigned this Aug 8, 2017
@dagnir dagnir mentioned this issue Sep 11, 2017
Closed
@dagnir dagnir mentioned this issue Nov 16, 2017
Merged
12 tasks
dagnir referenced this issue in dagnir/aws-sdk-java-v2 Dec 14, 2017
@dagnir
Introduce AwsRequest, AwsResponse
3d8db7a 
This commit replaces usages of the legacy AmazonWebServiceRequest and
AmazonWebServiceResponse with AwsRequest and AwsResponse respectively.

Other than the name change, this commit also introduces the following
changes:

 - Remove usage of RequestConfig in favor of SdkRequestOverrideConfig
   that is a member of AwSrequest/SdkRequest.

 - Like all model objects, request and response objects are now all
   completely immutable. In particular, AwsRequestOverrideConfig is
   immutable, which contains settings for request specific headers and
   query parameters that used to exist on AmazonWebServiceRequest level.

 - Generate service-specific request and response classes, e.g.
   ACMRequest and ACMResponse. This allows detection of request/response
   for a specific service via reflection within the interceptors.

   This also makes it easier to define service-specific request
   configuration and response metadata.

 - Introduce the ApiName object and SdkRequestOverrideConfig#addApiName
   that allows higher level library developers to include the name of
   their library in the User-Agent. This is similar to the internal-only
   RequestClientOptions#appendUserAgent method from v1.

Fixes #33
dagnir added a commit that referenced this issue Dec 14, 2017
@dagnir
Introduce AwsRequest, AwsResponse
9507395 
This commit replaces usages of the legacy AmazonWebServiceRequest and
AmazonWebServiceResponse with AwsRequest and AwsResponse respectively.

Other than the name change, this commit also introduces the following
changes:

 - Remove usage of RequestConfig in favor of SdkRequestOverrideConfig
   that is a member of AwSrequest/SdkRequest.

 - Like all model objects, request and response objects are now all
   completely immutable. In particular, AwsRequestOverrideConfig is
   immutable, which contains settings for request specific headers and
   query parameters that used to exist on AmazonWebServiceRequest level.

 - Generate service-specific request and response classes, e.g.
   ACMRequest and ACMResponse. This allows detection of request/response
   for a specific service via reflection within the interceptors.

   This also makes it easier to define service-specific request
   configuration and response metadata.

 - Introduce the ApiName object and SdkRequestOverrideConfig#addApiName
   that allows higher level library developers to include the name of
   their library in the User-Agent. This is similar to the internal-only
   RequestClientOptions#appendUserAgent method from v1.

Fixes #33
shorea pushed a commit that referenced this issue Aug 3, 2018
@dagnir
Introduce AwsRequest, AwsResponse
68c8c68 
This commit replaces usages of the legacy AmazonWebServiceRequest and
AmazonWebServiceResponse with AwsRequest and AwsResponse respectively.

Other than the name change, this commit also introduces the following
changes:

 - Remove usage of RequestConfig in favor of SdkRequestOverrideConfig
   that is a member of AwSrequest/SdkRequest.

 - Like all model objects, request and response objects are now all
   completely immutable. In particular, AwsRequestOverrideConfig is
   immutable, which contains settings for request specific headers and
   query parameters that used to exist on AmazonWebServiceRequest level.

 - Generate service-specific request and response classes, e.g.
   ACMRequest and ACMResponse. This allows detection of request/response
   for a specific service via reflection within the interceptors.

   This also makes it easier to define service-specific request
   configuration and response metadata.

 - Introduce the ApiName object and SdkRequestOverrideConfig#addApiName
   that allows higher level library developers to include the name of
   their library in the User-Agent. This is similar to the internal-only
   RequestClientOptions#appendUserAgent method from v1.

Fixes #33
@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagnir dagnir

Labels
2.0 New feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce AwsRequest, AwsResponse dagnir/aws-sdk-java-v2
3 participants
@dagnir @millems @justnance