Make ClasspathSdkHttpServiceProvider return more helpful errors

[barryoneill]

Describe the feature

Rather than messages like:

[info]   software.amazon.awssdk.core.exception.SdkClientException: Multiple HTTP implementations were found on the classpath. To avoid non-deterministic loading implementations, please explicitly provide an HTTP client via the client builders, set the software.amazon.awssdk.http.async.service.impl system property with the FQCN of the HTTP service to use as the default, or remove all but one HTTP implementation from the classpath

It would be helpful to include information on which implementations were found.

Thanks!

Use Case

The recently release CRT library is of great interest to my group, and we're slowly bringing it into our projects. However, a few teams have repeatedly tripped on transitive dependencies bringing in alternative providers.

This often results in one of the possible undesirable outcomes:

• They start setting system properties, which isn't often the most flexible solution
• They don't know how to resolve this issue since they're just the victims of sudden transitive bloat on an upstream library
• They rollback and don't bother upgrading the upstream library.

Proposed Solution

Instead of:

Multiple HTTP implementations were found on the classpath. To avoid non-deterministic loading implementations, please explicitly provide an HTTP client via the client builders, set the software.amazon.awssdk.http.async.service.impl system property with the FQCN of the HTTP service to use as the default, or remove all but one HTTP implementation from the classpath

It would be so much nicer if the message had the additional sentence:

.... remove all but one HTTP implementation from the classpath.  The multiple implementations found were [software.amazon.awssdk.http.crt.AwsCrtSdkHttpService, software.amazon.awssdk.http.nio.netty.NettySdkAsyncHttpService]

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

AWS Java SDK version used

19.0.2

JDK version used

2.20.4

Operating System and version

MacOS (all), Linux

[kovszilard]

❤️

[debora-ito]

Nice improvement! We'll take a look.

[barryoneill]

I can confirm this issue has been fixed since 2.20.23:

software.amazon.awssdk.core.exception.SdkClientException: Multiple HTTP implementations were found on the classpath. To avoid non-deterministic loading implementations, please explicitly provide an HTTP client via the client builders, set the software.amazon.awssdk.http.service.impl system property with the FQCN of the HTTP service to use as the default, or remove all but one HTTP implementation from the classpath.  The multiple implementations found were: [software.amazon.awssdk.http.apache.ApacheSdkHttpService,software.amazon.awssdk.http.urlconnection.UrlConnectionSdkHttpService]

Thank you @debora-ito and @dagnir !

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.