MediaLive waiter does not wait long enough. No configuration

[cobar79]

Describe the feature

Currently:
Wait until an input has been deleted It will poll every 5 seconds until a successful state has been reached. This will exit with a return code of 255 after 20 failed checks.

Allow the MediaLiveWaiter to be configured with poll interval and fail limit

Use Case

Can't delete MediaLive inputs and input security groups: software.amazon.awssdk.core.exception.SdkClientException: The waiter has exceeded the max retry attempts: 20

Proposed Solution

	ResponseOrException<DescribeInputResponse> responseOrException = mlWaiter
		.waitUntilInputDeleted(builder -> builder.inputId(inputId))
                .wait(10)
                .maxAttempts(50)
		.matched();

Other Information

	private void cleanUp(CreateInputSecurityGroupResponse securityGroupResponse) {
		if (securityGroupResponse != null) {
			log.info("DELETE Security {}", securityGroupResponse.securityGroup().id());
			Optional<DeleteInputSecurityGroupResponse> optSecurityGroup = deleteInputSecurityGroup(securityGroupResponse.securityGroup().id());
			if (optSecurityGroup.isPresent()) {
				log.info("Removed security {}", securityGroupResponse.securityGroup().id());
			}
		}
	}

	public Optional<DeleteInputSecurityGroupResponse> deleteInputSecurityGroup(String securityGroupId) {
		Optional<InputSecurityGroup> optSecurityGroup = findSecurityGroup(securityGroupId);
		if (optSecurityGroup.isPresent() && optSecurityGroup.get().hasInputs()) {
			InputSecurityGroup inputSecurityGroup = optSecurityGroup.get();
			log.info("Deleting {} inputs", inputSecurityGroup.inputs().size());
			inputSecurityGroup.inputs().forEach(this::deleteInput);
			DeleteInputSecurityGroupRequest deleteInputSecurityGroupRequest = DeleteInputSecurityGroupRequest.builder()
				.inputSecurityGroupId(securityGroupId)
				.build();
			DeleteInputSecurityGroupResponse deleteSecurityGroupResponse = mediaLiveClient.deleteInputSecurityGroup(deleteInputSecurityGroupRequest);
			log.info("{}:: deleted", securityGroupId);
			return Optional.of(deleteSecurityGroupResponse);
		} else {
			return Optional.empty();
		}
	}


	public DescribeInputResponse deleteInput(String inputId) {
		DescribeInputResponse describeInputResponse = waitTillInputDetached(inputId);
		log.info("{}:: input state {}", describeInputResponse.id(), describeInputResponse.state());
		DescribeInputResponse deleteResponse;
		try (MediaLiveWaiter mlWaiter = MediaLiveWaiter.builder().client(mediaLiveClient).build()) {
			ResponseOrException<DescribeInputResponse> responseOrException = mlWaiter
				.waitUntilInputDeleted(builder -> builder.inputId(inputId))
				.matched();
			deleteResponse = responseOrException.response()
				.orElseThrow(() -> new VideoServiceRuntimeException(inputId + ":: not deleted", ErrorReason.SERVICE_EXCEPTION));
			log.info("{}:: input deleted", inputId);
			return deleteResponse;
		}
	}
	
	public DescribeInputResponse waitTillInputDetached(String inputId) {
		log.info("Detaching Input {}", inputId);
		DescribeInputResponse detachInputResponse;
		try (MediaLiveWaiter mlWaiter = MediaLiveWaiter.builder().client(mediaLiveClient).build()) {
			ResponseOrException<DescribeInputResponse> responseOrException = mlWaiter
				.waitUntilInputDetached(builder -> builder.inputId(inputId)).matched();
			detachInputResponse = responseOrException.response()
				.orElseThrow(() -> new VideoServiceRuntimeException(inputId + ":: not be detached", ErrorReason.SERVICE_EXCEPTION));
			log.info("Detached Input {} state {}", detachInputResponse.id(), detachInputResponse.state());
			return detachInputResponse;
		}
	}

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

AWS Java SDK version used

2.25.14

JDK version used

OpenJDK 64-Bit Server VM Corretto-17.0.7.7.1 (build 17.0.7+7-LTS, mixed mode, sharing)

Operating System and version

windows 17

[debora-ito]

@cobar79 I think the WaiterOverrideConfiguration is what you're looking for - https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/medialive/waiters/MediaLiveWaiter.Builder.html

[cobar79]

@debora-ito Thank you.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

[cobar79]

		try (MediaLiveWaiter mlWaiter = MediaLiveWaiter.builder()
			.client(mediaLiveClient)
			.overrideConfiguration(override -> override
				.waitTimeout(Duration.ofSeconds(mediaLiveConfig.getInputDeleteWaitSeconds()))
				.maxAttempts(30)
				.build())
			.build()) {