Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Retry Throttling #645

Closed
madgnome opened this issue Aug 2, 2018 · 2 comments
Closed

Configurable Retry Throttling #645

madgnome opened this issue Aug 2, 2018 · 2 comments
Labels
1.x Parity feature-request A feature should be added or improved.

Comments

@madgnome
Copy link
Contributor

madgnome commented Aug 2, 2018

As indicated in AmazonAsyncHttpClient we should allow users to customize throttled retries:

private CapacityManager createCapacityManager() {
        // When enabled, total retry capacity is computed based on retry cost and desired number of retries.
        // TODO: Allow customers to configure throttled retries (https://github.com/aws/aws-sdk-java-v2/issues/17)
        return new CapacityManager(SdkDefaultRetrySetting.RETRY_THROTTLING_COST * SdkDefaultRetrySetting.THROTTLED_RETRIES);
    }

The linked issue is marked as fixed but the issue is not fixed.

Expected Behavior

User can customize throttled retries/capacity manager.

Current Behavior

Users can't customize throttled retries/capacity manager.

Your Environment

  • AWS Java SDK version used: 2.0.0-preview-11
zoewangg added a commit that referenced this issue Aug 3, 2018
@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
@millems millems changed the title Allow users to customize throttled retries Configurable Retry Throttling Jul 8, 2019
@millems millems added this to Backlog (Not Ordered) in New Features (Public) via automation Jul 8, 2019
@millems millems moved this from Backlog (Not Ordered) to SDK Team Backlog (Ordered) in New Features (Public) Jul 10, 2019
aws-sdk-java-automation added a commit that referenced this issue Oct 17, 2019
…7b3a4060

Pull request: release <- staging/12472c0a-f6f1-4548-8296-bbaf7b3a4060
@millems
Copy link
Contributor

millems commented Jul 21, 2021

This was fixed, but the github issue was never resolved. See here:

/**
* Configure the {@link RetryCondition} that should be used to throttle the number of retries attempted by the SDK client
* as a whole.
*
* <p>
* While any {@link RetryCondition} (or null) can be used, by convention these conditions are usually stateful and work
* globally for the whole client to limit the overall capacity of the client to execute retries.
*
* <p>
* By default the {@link TokenBucketRetryCondition} is used. This can be disabled by setting the value to {@code null}
* (not {@code RetryPolicy#none()}, which would completely disable retries).
*/
Builder retryCapacityCondition(RetryCondition retryCapacityCondition);

@millems millems closed this as completed Jul 21, 2021
New Features (Public) automation moved this from SDK Team Backlog (Ordered) to Done Jul 21, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Parity feature-request A feature should be added or improved.
Development

No branches or pull requests

4 participants