Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty HTTP Proxy Support #858

Closed
millems opened this issue Nov 20, 2018 · 13 comments
Closed

Netty HTTP Proxy Support #858

millems opened this issue Nov 20, 2018 · 13 comments
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@millems
Copy link
Contributor

millems commented Nov 20, 2018

The Apache HTTP implementation supports proxy configuration, but Netty does not. This feature should be added to Netty.

@dagnir dagnir self-assigned this Nov 30, 2018
@favetelinguis
Copy link

Any status updates on this?

@vinayys
Copy link

vinayys commented Mar 4, 2019

@dagnir - any update on this?

@dagnir
Copy link
Contributor

dagnir commented Mar 4, 2019

Hi @favetelinguis @vinayys we still have this planned, but have not begun work on this yet.

@alexmnyc
Copy link

alexmnyc commented Mar 7, 2019

this is very much needed for anyone working in enterprise,.,.,,,,

@IDWalsh
Copy link

IDWalsh commented Mar 8, 2019

This is a major issue for us adopting it.

@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
@danieladams456
Copy link

We want to use Spring Boot Webflux to build reactive services. Currently will have to wrap SDK calls in their own separate thread pools rather than just using Netty all the way through.

Spring Boot lets you inject a Reactor Netty HttpClient, but I assume you all are using Netty directly instead of Reactor Netty so that wouldn't be available.

@millems millems changed the title Support HTTP proxies with Netty Netty HTTP Proxy Support Jul 8, 2019
@millems millems added this to Backlog (Not Ordered) in New Features (Public) via automation Jul 8, 2019
@millems millems moved this from Backlog (Not Ordered) to Backlog (Ordered) in New Features (Public) Jul 8, 2019
@Krishnaghimire
Copy link

+1

@millems millems moved this from SDK Team Backlog (Ordered) to In Progress in New Features (Public) Aug 19, 2019
dagnir added a commit to dagnir/aws-sdk-java-v2 that referenced this issue Aug 20, 2019
dagnir added a commit that referenced this issue Aug 20, 2019
@millems millems moved this from In Progress to Done in New Features (Public) Oct 9, 2019
@BhargavChoksi
Copy link

Can we please add the proxy config support for DynamoDbAsyncClient ?????

I am in urgent need.

@dagnir
Copy link
Contributor

dagnir commented Oct 16, 2019

Hi @BhargavChoksi, this feature was built into the Netty HTTP client instead of at the service clients level. To use the Netty client's proxying feature with the DynamoDB client, you will need to configure the Netty client directly on the client:

        SdkAsyncHttpClient.Builder nettyBuilder = NettyNioAsyncHttpClient.builder()
                .proxyConfiguration(ProxyConfiguration.builder()
                        ...
                        .build());

        DynamoDbAsyncClient ddb = DynamoDbAsyncClient.builder()
                .httpClientBuilder(nettyBuilder)
                .build();

@BhargavChoksi
Copy link

BhargavChoksi commented Oct 16, 2019

Thanks a lot @dagnir, for your quick response. Here, I am able to set proxy-host and proxy-port.
How can I set proxy username and proxy-password?

It seems there is no way to set proxy-username ans proxy-password or I am horribly missing something?

final ProxyConfiguration proxyConfiguration =
ProxyConfiguration.builder().host("http-se.some.host.com").port(8080).build();

@dagnir
Copy link
Contributor

dagnir commented Oct 16, 2019

Hey @BhargavChoksi That is not currently supported at the moment. This is being tracked here: #1432

@dagnir
Copy link
Contributor

dagnir commented Oct 17, 2019

Marking this is done. Other proxy related features will be tracked separately (e.g. #1432)

@dagnir dagnir closed this as completed Oct 17, 2019
@LindaByrne
Copy link

Thanks for implementing this, it's working well for me.

One note though, the example configuration here shows using the KinesisClientUtil.createKinesisAsyncClient method which will override setting httpClientBuilder on the KinesisAsyncClientBuilder. Using the KinesisAsyncClient.builder() directly solves this issue.

aws-sdk-java-automation added a commit that referenced this issue May 27, 2020
…2184b821

Pull request: release <- staging/8f43e0d7-b401-409e-81ea-21882184b821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Development

No branches or pull requests