Merge s3 crt client change back in and fix region #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
dagnir
reviewed
Jan 25, 2022
| @@ -43,7 +44,7 @@ | |||
| */ | |||
| public class S3IntegrationTestBase extends AwsTestBase { | |||
|
|
|||
| protected static final Region DEFAULT_REGION = Region.US_WEST_2; | |||
| protected static final Region DEFAULT_REGION = Region.US_WEST_1; | |||
dagnir
approved these changes
Jan 25, 2022
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 19, 2024
…4670c0889 Pull request: release <- staging/7c3bf218-eda7-4b41-a976-ce04670c0889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA:
S3CrtAsyncHttpClientreliesSdkHttpRequest#urito set host header and since the region was not set on the S3AsyncClient before, the SdkHttpRequest#uri used the region resolved from the default region chain.