Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TM feature branch to mainline #3619

Merged
merged 45 commits into from
Dec 14, 2022
Merged

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Dec 14, 2022

Motivation and Context

Merge TM feature branch to mainline
All changes have been reviewed previously except 21243fb

joviegas and others added 30 commits June 27, 2022 18:02
…f S3ClientConfiguration with builder methods of S3AsyncClient (#3247)
… package. Added integration tests for s3 select using S3CrtAsyncClient (#3289)
1. Rename destinationDirectory to destination.
2. Move DownloadDirectoryRequest.prefix and delimiter to just rely on modifying the list requests.
3. Remove upload directory recursive option in favor of using maxDepth(1).
4. Rename UploadDirectoryRequest's prefix and delimiter to s3Prefix and s3Delimiter.
5. Rename ResumableFileDownload's to* and writeTo* methods to serializeTo*. Remove charsets from write/read methods, and just use UTF-8.
6. Do not base64 encode when writing ResumableFileDownload to disk.
* Refactoring of Transfer manager APIs

* Merging the integ test failure Pr 2119 from stagging branch
* Add flexible checksum support and update perf tests

* fix checkstyle

* Update based on latest change
…File (#3357)

* Implement pause and resume for uploadFile

* Fix merge conflict

* Adding more tests

* Add more tests

* Update Javadocs

* address feedback
…nt (#3403)

* Implement automatic multipart copy functionality in S3 CRT async client

* Add more tests

* fix cancellation logic

* Refactor CopyRequestProvider, fix request conversion and add more tests

* Fix checkstyle
* Remove use of Junit4, clean up and consolidate tests in tm module

* Ignoring the test if unicode can't be used as directory name
…#3432)

* Support serialization and deserialization of ResumableFileUpload

* Address feedback

* Empty json should be unmarshalled to empty map
* Errors should not be wrapped

* update handleException()

* Changelog entry

* Resolve comments
Update changelog description, refactor handleException(), add test

* Add failed message to SdkException
* Replace inline snippets with external compilable snippets

* Fix build and address feedback

* Fix build
* Only use CRT flexible checksum for getObject and putObject

* Fix build
* integrate with crt s3 flow control

* Update benchmark code

* Add backpressure config

* Change window size

* Update initial window size

* Change intial window size

* Use heap max memory for initial window size

* Give some buffer

* change window size

* Make read buffer size configurable

* Log result to a file

* Various updates

* Various updates

* Add CRT benchmark

* Various updates

* Fix checkstyle errors and tests

* Fix flaky test

* Fix checkstyle errors

* Add validation

* Add tests
#3549)

* For copy operation, always forward multipart copy exception from one request to other multipart copy requests
* Add benchmarks for copy, uploadDirectory and downloadDirectory
* Update sample code and fix snippet path

* Fix link
* Integrate with CRT checksum fix
)

* Rname sourceDirectory to source and add S3AsycncClient#crtCreate
* Use ByteBufferStoringSubscriber

* Add a comment

* Create constant for bytes bufferred
… rename S3TransferManager.builder().s3AsyncClient to .s3Client (#3584)
#3586)

* Throw UnsupportedOperationException if a user tries to pause a upload with non CRT-based S3 client
* Integrate with latest CRT pause/resume fix
* Bump CRT version
* Make aws-crt an optional dependency in s3-transfer-manager module.

* Update README
@zoewangg zoewangg requested a review from a team as a code owner December 14, 2022 06:36
@zoewangg
Copy link
Contributor Author

Integ and stability tests passed

@zoewangg zoewangg enabled auto-merge (squash) December 14, 2022 18:37
@zoewangg zoewangg merged commit 63ade31 into master Dec 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 134 Code Smells

66.3% 66.3% Coverage
4.7% 4.7% Duplication

@millems millems deleted the feature/master/transfermanager-GA branch February 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants