Codegen the partitions data

[sugmanue]

Motivation and Context

The partition data is currently embedded in a JSON string inside the DefaultPartitionDataProvider class and then parsed and converted into Java classes at runtime lazyly, this adds considerably slows down its first usage and also adds the risk of parsing errors at runtime. This change does the translation at codegen time instead and puts the data behind an inner class such that it would still be lazily initialized by the Java runtime.

This change will improve cold-start performance and the methods needed to parse from JSON are still present to it won't close the door for implementing another provider that will load the data from a JSON file at runtime.

The new codegen class looks like this:

/*
 * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 * 
 * Licensed under the Apache License, Version 2.0 (the "License"). You may not use this file except in compliance with
 * the License. A copy of the License is located at
 * 
 * http://aws.amazon.com/apache2.0
 * 
 * or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
 * CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions
 * and limitations under the License.
 */

package software.amazon.awssdk.services.s3.endpoints.internal;

import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.SdkInternalApi;

@Generated("software.amazon.awssdk:codegen")
@SdkInternalApi
public final class DefaultPartitionDataProvider implements PartitionDataProvider {
    @Override
    public Partitions loadPartitions() {
        return LazyPartitionsContainer.PARTITIONS;
    }

    static class LazyPartitionsContainer {
        static final Partitions PARTITIONS = Partitions
                .builder()
                .version("1.1")
                .addPartition(
                        Partition
                                .builder()
                                .id("aws")
                                .regionRegex("^(us|eu|ap|sa|ca|me|af|il)\\-\\w+\\-\\d+$")
                                .putRegion("af-south-1", RegionOverride.builder().build())
                                .putRegion("ap-east-1", RegionOverride.builder().build())
                                .putRegion("ap-northeast-1", RegionOverride.builder().build())
                                .putRegion("ap-northeast-2", RegionOverride.builder().build())
                                .putRegion("ap-northeast-3", RegionOverride.builder().build())
                                .putRegion("ap-south-1", RegionOverride.builder().build())
                                .putRegion("ap-south-2", RegionOverride.builder().build())
                                .putRegion("ap-southeast-1", RegionOverride.builder().build())
                                .putRegion("ap-southeast-2", RegionOverride.builder().build())
                                .putRegion("ap-southeast-3", RegionOverride.builder().build())
                                .putRegion("ap-southeast-4", RegionOverride.builder().build())
                                .putRegion("aws-global", RegionOverride.builder().build())
                                .putRegion("ca-central-1", RegionOverride.builder().build())
                                .putRegion("eu-central-1", RegionOverride.builder().build())
                                .putRegion("eu-central-2", RegionOverride.builder().build())
                                .putRegion("eu-north-1", RegionOverride.builder().build())
                                .putRegion("eu-south-1", RegionOverride.builder().build())
                                .putRegion("eu-south-2", RegionOverride.builder().build())
                                .putRegion("eu-west-1", RegionOverride.builder().build())
                                .putRegion("eu-west-2", RegionOverride.builder().build())
                                .putRegion("eu-west-3", RegionOverride.builder().build())
                                .putRegion("il-central-1", RegionOverride.builder().build())
                                .putRegion("me-central-1", RegionOverride.builder().build())
                                .putRegion("me-south-1", RegionOverride.builder().build())
                                .putRegion("sa-east-1", RegionOverride.builder().build())
                                .putRegion("us-east-1", RegionOverride.builder().build())
                                .putRegion("us-east-2", RegionOverride.builder().build())
                                .putRegion("us-west-1", RegionOverride.builder().build())
                                .putRegion("us-west-2", RegionOverride.builder().build())
                                .outputs(
                                        Outputs.builder().dnsSuffix("amazonaws.com").dualStackDnsSuffix("api.aws")
                                                .supportsFips(true).supportsDualStack(true).build()).build())
                .addPartition(
                        Partition
                                .builder()
                                .id("aws-cn")
                                .regionRegex("^cn\\-\\w+\\-\\d+$")
                                .putRegion("aws-cn-global", RegionOverride.builder().build())
                                .putRegion("cn-north-1", RegionOverride.builder().build())
                                .putRegion("cn-northwest-1", RegionOverride.builder().build())
                                .outputs(
                                        Outputs.builder().dnsSuffix("amazonaws.com.cn")
                                                .dualStackDnsSuffix("api.amazonwebservices.com.cn").supportsFips(true)
                                                .supportsDualStack(true).build()).build())
                .addPartition(
                        Partition
                                .builder()
                                .id("aws-us-gov")
                                .regionRegex("^us\\-gov\\-\\w+\\-\\d+$")
                                .putRegion("aws-us-gov-global", RegionOverride.builder().build())
                                .putRegion("us-gov-east-1", RegionOverride.builder().build())
                                .putRegion("us-gov-west-1", RegionOverride.builder().build())
                                .outputs(
                                        Outputs.builder().dnsSuffix("amazonaws.com").dualStackDnsSuffix("api.aws")
                                                .supportsFips(true).supportsDualStack(true).build()).build())
                .addPartition(
                        Partition
                                .builder()
                                .id("aws-iso")
                                .regionRegex("^us\\-iso\\-\\w+\\-\\d+$")
                                .putRegion("aws-iso-global", RegionOverride.builder().build())
                                .putRegion("us-iso-east-1", RegionOverride.builder().build())
                                .putRegion("us-iso-west-1", RegionOverride.builder().build())
                                .outputs(
                                        Outputs.builder().dnsSuffix("c2s.ic.gov").dualStackDnsSuffix("c2s.ic.gov")
                                                .supportsFips(true).supportsDualStack(false).build()).build())
                .addPartition(
                        Partition
                                .builder()
                                .id("aws-iso-b")
                                .regionRegex("^us\\-isob\\-\\w+\\-\\d+$")
                                .putRegion("aws-iso-b-global", RegionOverride.builder().build())
                                .putRegion("us-isob-east-1", RegionOverride.builder().build())
                                .outputs(
                                        Outputs.builder().dnsSuffix("sc2s.sgov.gov").dualStackDnsSuffix("sc2s.sgov.gov")
                                                .supportsFips(true).supportsDualStack(false).build()).build())
                .addPartition(
                        Partition
                                .builder()
                                .id("aws-iso-e")
                                .regionRegex("^eu\\-isoe\\-\\w+\\-\\d+$")
                                .outputs(
                                        Outputs.builder().dnsSuffix("cloud.adc-e.uk").dualStackDnsSuffix("cloud.adc-e.uk")
                                                .supportsFips(true).supportsDualStack(false).build()).build())
                .addPartition(
                        Partition
                                .builder()
                                .id("aws-iso-f")
                                .regionRegex("^us\\-isof\\-\\w+\\-\\d+$")
                                .outputs(
                                        Outputs.builder().dnsSuffix("csp.hci.ic.gov").dualStackDnsSuffix("csp.hci.ic.gov")
                                                .supportsFips(true).supportsDualStack(false).build()).build()).build();
    }
}

Modifications

Testing

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[L-Applin]

Are there no existing code-gen unit-test for this class? I would have expected them to require change since code-gen changed. In all cases, we probably should add one. Also, is there any way to check for potential regression in the returned partition object vs what was there before?

[sonarcloud]

Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[L-Applin]

all codegen-generated-classes-test run fine, which uses partition metadata in some way so I think we are good