Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ARN toString to print a valid ARN when there's no region or acountId #4944

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-AWSSDKforJavav2-51797eb.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "AWS SDK for Java v2",
"contributor": "Madrigal",
"description": "Modify ARN toString to print a valid ARN when there's no region or acountId"
}
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,9 @@ public String toString() {
+ ":"
+ this.service
+ ":"
+ region
+ (region == null ? "" : region)
+ ":"
+ this.accountId
+ (this.accountId == null ? "" : this.accountId)
+ ":"
+ this.resource;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,22 @@ public void arnWithQualifiedResource_ParsesBackToString() {
assertThat(arn.resourceAsString()).isEqualTo("myresource:foobar:1");
}

@Test
public void arnWithMinimalResources_ParsesBackToString() {
String arnString = "arn:aws:s3:::bucket";
Arn arn = Arn.fromString(arnString);
assertThat(arn.toString()).isEqualTo(arnString);
assertThat(arn.resourceAsString()).isEqualTo("bucket");
}

@Test
public void arnWithoutRegion_ParsesBackToString() {
String arnString = "arn:aws:iam::123456789012:root";
Arn arn = Arn.fromString(arnString);
assertThat(arn.toString()).isEqualTo(arnString);
assertThat(arn.resourceAsString()).isEqualTo("root");
}

@Test
public void arnWithResourceTypeAndResource_ParsesCorrectly() {
String arnString = "arn:aws:s3:us-east-1:12345678910:bucket:foobar";
Expand Down
Loading