Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Non proxy host settings in the ProxyConfiguration for Crt http client. #4974

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

joviegas
Copy link
Contributor

Support Non proxy host settings in the ProxyConfiguration for Crt http client.

Motivation and Context

  • Need An API in ProxyConfiguration of CRT Http client to specify
  • Also since we are making the Default configuration of Proxy to use Env variables and proxy settings we need to make sure the Non Proxy settings are picked up by CRT which are specified in env variables and ssystem settings

Modifications

Testing

  • Added Junits

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

License

  • I confirm that this pull request can be released under the Apache 2 license

Re-merging PR #4962

@joviegas joviegas requested a review from a team as a code owner February 27, 2024 23:20
@joviegas joviegas enabled auto-merge (squash) February 29, 2024 15:28
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@joviegas joviegas merged commit a6c9092 into master Feb 29, 2024
16 of 17 checks passed
@joviegas joviegas deleted the joviegas/non_proxy_for_crt branch May 15, 2024 20:30
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
…p client. (aws#4974)

* Support Non proxy host settings in the ProxyConfiguration for Crt http client.

* Handled comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants