Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s3-benchmarks to support java-based multipart download. #5003

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

L-Applin
Copy link
Contributor

@L-Applin L-Applin commented Mar 7, 2024

The s3-benchmarks needed some update to complete perf testing.

IMPORTANT: this PR also removes the transfer manager workaround for multipart, since it is required to test transfer manager with s3 multipart client.

Motivation and Context

While testing S3MultipartClient, noticed some problems/missing features.

Modifications

  • remove TM workaround so that perf test run with it multipart client
  • Add config to specify java client to TM benchmarks
  • Fix JavaBased download benchmarks for multiple iterations with file
  • Fix JavaBased download benchmarks for large objects with in-memory

testing

These changes have been used to run perf tests iterations already.

@L-Applin L-Applin requested a review from a team as a code owner March 7, 2024 20:11
…nt. Use TransferManagerBenchmark.httpClient in BaseJavaS3ClientBenchmark
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
70.4% Coverage on New Code (required ≥ 80%)
4.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@L-Applin L-Applin merged commit 7d82774 into feature/master/s3mpu Mar 11, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants