Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider name when providers resolve identity #5040

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add provider name when providers resolve identity #5040

merged 1 commit into from
Mar 26, 2024

Conversation

cenedhryn
Copy link
Contributor

@cenedhryn cenedhryn commented Mar 25, 2024 •
edited
Loading

Motivation and Context

In previous PRs (#5008), (#5029), Identity got a new field, provider, to identify the source of the identity and later extracting this value and adding it to the user agent.

This PR adds support for this mechanism to all public SDK identity providers except for StaticCredentialsProvider, which was previously modified.

@cenedhryn cenedhryn requested a review from a team as a code owner March 25, 2024 16:07
@cenedhryn cenedhryn changed the base branch from master to feature/master/credentials-source March 25, 2024 16:07
@cenedhryn cenedhryn changed the title Salande/credentials source providers Add provider name when providers resolve identity Mar 25, 2024
@cenedhryn cenedhryn force-pushed the salande/credentials-source-providers branch from 08719f1 to c8e787a Compare March 25, 2024 17:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.6% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarCloud

@cenedhryn cenedhryn merged commit 8825303 into feature/master/credentials-source Mar 26, 2024
17 checks passed
cenedhryn added a commit that referenced this pull request Apr 2, 2024
@cenedhryn
Recording identity provider names in user agent string (#5047)
d3e828a 
* Adding source to identity (provider name) (#5008)

* Adding identity provider source to user agent string (#5029)

* Adds provider name to all SDK identity providers (#5040)
@cenedhryn cenedhryn deleted the salande/credentials-source-providers branch May 13, 2024 00:52
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
@cenedhryn @akidambisrinivasan
Recording identity provider names in user agent string (aws#5047)
949aa40 
* Adding source to identity (provider name) (aws#5008)

* Adding identity provider source to user agent string (aws#5029)

* Adds provider name to all SDK identity providers (aws#5040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cenedhryn @dagnir