-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Progress Listener Invocation methods to Asynchronous code paths #5044
base: feature/anirudkr-progress-listener
Are you sure you want to change the base?
Add Progress Listener Invocation methods to Asynchronous code paths #5044
Conversation
…callback methods in ProgressUpdater
…e Progress Updater
…to prepare the request
|
|
||
public BytesSentTrackingPublisher(Publisher<ByteBuffer> upstream, | ||
ProgressUpdater progressUpdater, | ||
Optional<Long> contentLength) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional should not be used in method parameters. https://github.com/aws/aws-sdk-java-v2/blob/master/docs/design/UseOfOptional.md
...ftware/amazon/awssdk/core/internal/http/pipeline/stages/PreExecutionUpdateProgressStage.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/awssdk/core/internal/http/pipeline/stages/PreExecutionUpdateProgressStage.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/awssdk/core/internal/http/pipeline/stages/PreExecutionUpdateProgressStage.java
Outdated
Show resolved
Hide resolved
.../awssdk/core/internal/http/pipeline/stages/AsyncExecutionFailureExceptionReportingStage.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/core/internal/http/pipeline/stages/MakeAsyncHttpRequestStage.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/core/internal/http/pipeline/stages/MakeAsyncHttpRequestStage.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/awssdk/core/internal/http/pipeline/stages/ProgressUpdateStageTest.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/awssdk/core/internal/http/pipeline/stages/ProgressUpdateStageTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/software/amazon/awssdk/core/internal/metrics/BytesReadTrackingPublisherTest.java
Outdated
Show resolved
Hide resolved
…ad and Download operations in a wya in which BytesReadTrackingPublisher can be reused for upload and download
|
Asynchronous request Path to include Progress Listener invocations to track transactions
Motivation and Context
This is a parity feature gap between 1.x and 2.x
Modifications
Added callbacks :
in asynchronous code path.
Testing
Unit Tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License