Add package mapping for the new module and exclude it from javadoc exe… #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
commented
May 7, 2024
| <configuration> | ||
| <archive> | ||
| <manifestEntries> | ||
| <!-- TODO: is this really needed since we don't expect users to use our recipe classes directly ? --> |
There was a problem hiding this comment.
We'll address this in user experience review.
zoewangg
commented
May 7, 2024
| @@ -43,6 +43,7 @@ | |||
|
|
|||
| "dynamodb": { "packageName": "AwsJavaSdk-DynamoDb" }, | |||
| "waf": { "packageName": "AwsJavaSdk-Waf" }, | |||
| "migration-tool": { "packageName": "AwsJavaSdk-MigrationTool"}, | |||
There was a problem hiding this comment.
The alternative I have in mind is AwsJavaSdk-Tooling-Migration. Feedback is welcome
joviegas
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cution
Motivation and Context
Modifications
Note there are some other steps for new module such as adding it to bom, but they are not applicable to this new module
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License