Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileAsyncResponseTransformer - write to position #5241

Merged
merged 4 commits into from
May 23, 2024

Conversation

L-Applin
Copy link
Contributor

Add a new option to FileTransformerConfiguration WRITE_TO_POSITION that will start writing the incoming data to the file at the specified byte position.

Motivation and Context

Required to implement the pause and resume logic for multipart download in the java-based s3 async client.

Modifications

  • Add a new Enum value to FileTransformerConfiguration. FileWriteOption
  • Add a new configuration to FileTransformerConfiguration: location

Testing

Added unit test.

@L-Applin L-Applin requested a review from a team as a code owner May 23, 2024 16:27
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@L-Applin L-Applin merged commit 85a8f89 into feature/master/s3mpu May 23, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants