Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redirect (302) #903

Closed
dadoonet opened this issue Oct 25, 2016 · 5 comments
Closed

Support redirect (302) #903

dadoonet opened this issue Oct 25, 2016 · 5 comments
Labels
feature-request A feature should be added or improved.

Comments

@dadoonet
Copy link

Hi guys,

I got this demand recently on a project where I'm using AWS SDK and I wonder if this is something you can support internally in the Java SDK as a new followRedirect option or something?

Unless this is already supported and I missed it in docs?

Thanks!

@dagnir
Copy link
Contributor

dagnir commented Oct 25, 2016

Hi @dadoonet, you're correct the SDK does not follow redirects. Unfortunately, this would be a breaking change since it will change the behavior of our clients.

@dadoonet
Copy link
Author

dadoonet commented Oct 25, 2016

@dagnir Thanks for confirming. Could this become an option (false by default) so it does not break anything unless you explicitly opt-in?

@dagnir
Copy link
Contributor

dagnir commented Oct 25, 2016

I will bring it up with the rest of the team to see if it makes sense for us to support this configuration.

@dagnir dagnir added the feature-request A feature should be added or improved. label Oct 25, 2016
@dagnir
Copy link
Contributor

dagnir commented Oct 27, 2016

Hi @dadoonet, after much consideration, we have decided that we will not be supporting this feature in the SDK. One reason for this decision is that we feel it would be too confusing for the majority of AWS customers. This is because aside from S3, which does send 3xx responses, it is not part of the service contract in AWS to send redirect responses, so it's not something that should need to be accounted for. Adding support for this feature would also complicate the code as there are certain parts of the S3 and core runtime codebases that depends on the current behavior and we would need to make sure that that functionality would still work even in the presence of automatic redirect following; such an undertaking could also have the potential to introduce subtle bugs that could also affect customers who are not opting into this feature.

@dagnir dagnir closed this as completed Oct 27, 2016
@dadoonet
Copy link
Author

Understood. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants