NullPointerException in case of permission denied errors #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmission denied exception, for example), calling shutdown() on a null object will throw a NullPointerException, hidding the previous exception.
zachmu
pushed a commit
that referenced
this pull request
Sep 18, 2012
NullPointerException in case of permission denied errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases that the instantiation of the JobStatusMonitor class will fail, for example, if the credentials used don't have permissions to access the required resources.
If the instantiation of the JobStatusMonitor fail (lines 320 or 322 of the ArchiveTransferManager.java file), an exception describing the error will be thrown. But the finally clause at the end of the method will call shutdown() on an null object, resulting in a new NullPointerException. This new exception makes hard to the user to know what failed during the API execution.
This change checks if the jobStatusMonitor variable is not null before calling shutdown(). This way, if an error occurs, the exception with a clear message can be caught by the user.