Only parse fields we need to validate the message #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acinader
force-pushed
the
fix-decode-json-message-exception
branch
from
528f6c3
to
478415a
Compare
The simple message parser was parsing MessageAttributes that was causing the important Type field to get overwritten incorrectly. By ignoring fields that we don't need, we wont overwrite top level fields with nested fields.
acinader
force-pushed
the
fix-decode-json-message-exception
branch
from
478415a
to
8482a46
Compare
|
Change looks good, running through some internal tests before merging. Can you confirm you are submitting under the Apache 2.0 license? |
|
@shorea yes, submitted under apache 2.0 and I added the license to the new test file. |
shorea
added a commit
that referenced
this pull request
Oct 20, 2015
Only parse fields we need to validate the message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple message parser was parsing MessageAttributes that was causing the important Type
field to get overwritten incorrectly. By ignoring fields that we don't need, we wont overwrite
top level fields with nested fields.
#510