-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Transform checks for error.code to error.name in promise catch (#810)
- Loading branch information
Showing
10 changed files
with
345 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "aws-sdk-js-codemod": patch | ||
| --- | ||
|
|
||
| Transform checks for error.code to error.name in promise catch |
35 changes: 31 additions & 4 deletions
35
src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,42 @@ | ||
| import AWS from "aws-sdk"; | ||
|
|
||
| const client = new AWS.S3(); | ||
| const Bucket = "bucket-name"; | ||
|
|
||
| try { | ||
| await client.createBucket({ | ||
| Bucket: "bucket" | ||
| }).promise(); | ||
| await client.createBucket({ Bucket }).promise(); | ||
| } catch (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch((error) => { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch(function (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); |
40 changes: 36 additions & 4 deletions
40
src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,47 @@ | ||
| import AWS from "aws-sdk"; | ||
|
|
||
| export const func = async (client: AWS.S3) => { | ||
| const Bucket = "bucket-name"; | ||
|
|
||
| export const funcTryCatch = async (client: AWS.S3) => { | ||
| try { | ||
| await client.createBucket({ | ||
| Bucket: "bucket" | ||
| }).promise(); | ||
| await client.createBucket({ Bucket }).promise(); | ||
| } catch (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export const funcPromiseCatchArrowFn = async (client: AWS.S3) => { | ||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch((error) => { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| export const funcPromiseCatchFn = async (client: AWS.S3) => { | ||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch(function (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
| } |
33 changes: 29 additions & 4 deletions
33
src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,40 @@ | ||
| import { S3 } from "@aws-sdk/client-s3"; | ||
|
|
||
| const client = new S3(); | ||
| const Bucket = "bucket-name"; | ||
|
|
||
| try { | ||
| await client.createBucket({ | ||
| Bucket: "bucket" | ||
| }); | ||
| await client.createBucket({ Bucket }); | ||
| } catch (error) { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch((error) => { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch(function (error) { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); |
38 changes: 34 additions & 4 deletions
38
src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,45 @@ | ||
| import { S3 } from "@aws-sdk/client-s3"; | ||
|
|
||
| export const func = async (client: S3) => { | ||
| const Bucket = "bucket-name"; | ||
|
|
||
| export const funcTryCatch = async (client: S3) => { | ||
| try { | ||
| await client.createBucket({ | ||
| Bucket: "bucket" | ||
| }); | ||
| await client.createBucket({ Bucket }); | ||
| } catch (error) { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export const funcPromiseCatchArrowFn = async (client: S3) => { | ||
| client | ||
| .createBucket({ Bucket }) | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch((error) => { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| export const funcPromiseCatchFn = async (client: S3) => { | ||
| client | ||
| .createBucket({ Bucket }) | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch(function (error) { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
| } |
35 changes: 31 additions & 4 deletions
35
src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,42 @@ | ||
| import { S3 } from "aws-sdk"; | ||
|
|
||
| const client = new S3(); | ||
| const Bucket = "bucket-name"; | ||
|
|
||
| try { | ||
| await client.createBucket({ | ||
| Bucket: "bucket" | ||
| }).promise(); | ||
| await client.createBucket({ Bucket }).promise(); | ||
| } catch (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch((error) => { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch(function (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); |
38 changes: 35 additions & 3 deletions
38
src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,47 @@ | ||
| import { S3 } from "aws-sdk"; | ||
|
|
||
| const Bucket = "bucket-name"; | ||
|
|
||
| export const func = async (client: S3) => { | ||
| try { | ||
| await client.createBucket({ | ||
| Bucket: "bucket" | ||
| }).promise(); | ||
| await client.createBucket({ Bucket }).promise(); | ||
| } catch (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export const funcPromiseCatchArrowFn = async (client: S3) => { | ||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch((error) => { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| export const funcPromiseCatchFn = async (client: S3) => { | ||
| client | ||
| .createBucket({ Bucket }) | ||
| .promise() | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch(function (error) { | ||
| if (error.code === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
| } |
33 changes: 29 additions & 4 deletions
33
src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,40 @@ | ||
| import { S3 } from "@aws-sdk/client-s3"; | ||
|
|
||
| const client = new S3(); | ||
| const Bucket = "bucket-name"; | ||
|
|
||
| try { | ||
| await client.createBucket({ | ||
| Bucket: "bucket" | ||
| }); | ||
| await client.createBucket({ Bucket }); | ||
| } catch (error) { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch((error) => { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); | ||
|
|
||
| client | ||
| .createBucket({ Bucket }) | ||
| .then((response) => { | ||
| // Consume the response | ||
| }) | ||
| .catch(function (error) { | ||
| if (error.name === "BucketAlreadyExists") { | ||
| // Handle BucketAlreadyExists error | ||
| } else { | ||
| // Handle other error. | ||
| } | ||
| }); |
Oops, something went wrong.