Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn default compressionLevel #645

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Use yarn default compressionLevel #645

merged 2 commits into from
Oct 24, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 24, 2023

Issue

Follow-up to #632
The yarn compressionLevel is 'mixed' by default https://yarnpkg.com/configuration/yarnrc#compressionLevel

Description

Unset yarn compressionLevel default value

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 051c6be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr
Copy link
Member Author

trivikr commented Oct 24, 2023

As per the update in lockfile, the compressionLevel seems to be 0 by default.

As per CI, looks like the dependencies size was increased

➤ YN0000: ┌ Fetch step
Fetch step
  ➤ YN0013: │ 646 packages were added to the project, and 646 were removed (+ 208.26 MiB).
➤ YN0000: └ Completed in 6s 784ms

@trivikr trivikr closed this Oct 24, 2023
@trivikr trivikr deleted the yarn-compression-level branch October 24, 2023 06:07
@trivikr trivikr restored the yarn-compression-level branch October 24, 2023 14:48
@trivikr
Copy link
Member Author

trivikr commented Oct 24, 2023

The default compression level was set to 0 in yarn@4.0.0 for reasons explained in yarnpkg/berry#5526

Since we don't vendor our dependencies and codemod does not have large number of dependencies - we can install our dependencies without compression.

@trivikr trivikr reopened this Oct 24, 2023
@trivikr trivikr marked this pull request as ready for review October 24, 2023 14:50
@trivikr trivikr requested a review from a team as a code owner October 24, 2023 14:50
@trivikr
Copy link
Member Author

trivikr commented Oct 24, 2023

The CI cache size actually reduced from 50MB to 46 MB after switching to default compressionLevel

ci-cache-size

@trivikr trivikr changed the title Unset yarn compressionLevel default value Use yarn default compressionLevel Oct 24, 2023
@trivikr trivikr merged commit 4450766 into main Oct 24, 2023
4 checks passed
@trivikr trivikr deleted the yarn-compression-level branch October 24, 2023 14:55
Copy link
Contributor

github-actions bot commented Nov 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant