Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub repo link on npmjs #8

Closed
trivikr opened this issue Nov 4, 2019 · 5 comments
Closed

Update GitHub repo link on npmjs #8

trivikr opened this issue Nov 4, 2019 · 5 comments

Comments

@trivikr
Copy link
Member

trivikr commented Nov 4, 2019

Describe the bug
npmjs website of @aws-crypto packages links to aws-javascript-crypto-helpers repo which doesn't exist

To Reproduce

Expected behavior
The github link in npmjs website links to aws-sdk-js-crypto-helpers

Screenshots
aws-crypto:crc32
@trivikr
Copy link
Member Author

trivikr commented Nov 4, 2019

We noticed this issue in dependabot PR aws/aws-sdk-js-v3#436

@seebees
Copy link
Contributor

seebees commented Nov 4, 2019

Ok, simple to fix.

thesnicketylemon added a commit that referenced this issue Nov 7, 2019
@thesnicketylemon
fix: Corrected all the @aws-crypto package.json files to point to the…
e693750 
… aws-sdk-js-crypto-helpers. It was previously pointing to a non-existent repository.

see the issue for specific details

closes issue #8
@thesnicketylemon thesnicketylemon mentioned this issue Nov 7, 2019
Merged
thesnicketylemon added a commit that referenced this issue Nov 7, 2019
@thesnicketylemon
fix: Changed all the aws-crypto package.json files to point to the co…
524399e 
…rrect Git repository

Changed all the package.json files to point to the aws-sdk-js-crypto-helpers Git repository. It was previously pointing to a non-existent repository i.e. aws-javascript-crypto-helpers

closes issue #8
thesnicketylemon added a commit that referenced this issue Nov 8, 2019
@thesnicketylemon
fix: Changed package.json files to point to the right Git repo
00b036c 
Changed all the package.json files to point to the aws-sdk-js-crypto-helpers Git repository. It was previously pointing to a non-existent repository i.e. aws-javascript-crypto-helpers

closes issue #8
seebees pushed a commit that referenced this issue Nov 8, 2019
@DeepikaVasudevan @seebees
fix: Changed package.json files to point to the right Git repo (#9)
028245d 
Changed all the package.json files to point to the aws-sdk-js-crypto-helpers Git repository. It was previously pointing to a non-existent repository i.e. aws-javascript-crypto-helpers

closes issue #8
@trivikr
Copy link
Member Author

trivikr commented Nov 12, 2019

Any update on this request?
The GitHub link on npmjs website is not updated yet https://www.npmjs.com/package/@aws-crypto/sha256-js

Do you have to create a new release?

@seebees
Copy link
Contributor

seebees commented Nov 13, 2019

@trivikr Yes, I should be able to push a release to this today.

@trivikr
Copy link
Member Author

trivikr commented Nov 18, 2019

Fixed with 0.1.0-preview.3 release

@trivikr trivikr closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seebees @trivikr