fix: lerna version maintains package-lock #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves aws#13 Lerna version 3.18.2 will version package-lock.json files. This means that if they are in .gitingnore the version command will fail. Better visibility into versions should help debugging.
| @@ -9,8 +9,6 @@ | |||
| # Artifacts | |||
| build | |||
| node_modules | |||
| package-lock.json | |||
| package.json.decrypt | |||
There was a problem hiding this comment.
What does the package.json.decrypt file do? That sounds like something that might be good to keep out of version control.
There was a problem hiding this comment.
In trying to work out what was going wrong,
we synced the .gitignore files from the ESDK JS.
This is from that file.
There was a problem hiding this comment.
<from offline discussion/>
Specifically, it sounds like this was something that we added because of an artifact that a manual test created, not something that we expect to ever exist again.
I wanted to make sure that we were not blindly removing something that was protecting us from an unintended leak from a build tool or similar.
agray256
approved these changes
Nov 14, 2019
mattsb42-aws
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #13
Lerna version 3.18.2 will version package-lock.json files.
This means that if they are in .gitingnore the version command will fail.
Better visibility into versions should help debugging.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.