fix(middleware-host-header): populate :authority pseudo-header with a…

…uthority section of target URI (#5369)
aws · Oct 16, 2023 · 242a32c · 242a32c
1 parent c361378
commit 242a32c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/middleware-host-header/src/index.spec.ts b/packages/middleware-host-header/src/index.spec.ts
@@ -57,11 +57,12 @@ describe("hostHeaderMiddleware", () => {
       input: {},
       request: new HttpRequest({
         hostname: "foo.amazonaws.com",
+        port: 8080,
         headers: { host: "random host" },
       }),
     });
     expect(mockNextHandler.mock.calls.length).toEqual(1);
     expect(mockNextHandler.mock.calls[0][0].request.headers.host).not.toBeDefined();
-    expect(mockNextHandler.mock.calls[0][0].request.headers[":authority"]).toEqual("");
+    expect(mockNextHandler.mock.calls[0][0].request.headers[":authority"]).toEqual("foo.amazonaws.com:8080");
   });
 });
diff --git a/packages/middleware-host-header/src/index.ts b/packages/middleware-host-header/src/index.ts
@@ -33,7 +33,7 @@ export const hostHeaderMiddleware =
     //reference: https://nodejs.org/dist/latest-v13.x/docs/api/errors.html#ERR_HTTP2_INVALID_CONNECTION_HEADERS
     if (handlerProtocol.indexOf("h2") >= 0 && !request.headers[":authority"]) {
       delete request.headers["host"];
-      request.headers[":authority"] = "";
+      request.headers[":authority"] = request.hostname + (request.port ? ":" + request.port : "");
       //non-H2 request and 'host' header is not set, set the 'host' header to request's hostname.
     } else if (!request.headers["host"]) {
       let host = request.hostname;