fix(middleware-websocket): pass options to presign in WebsocketSignat…

…ureV4 sign (#5015)
aws · Jul 26, 2023 · 3663a9b · 3663a9b
1 parent e8f3d8f
commit 3663a9b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/middleware-websocket/src/WebsocketSignatureV4.spec.ts b/packages/middleware-websocket/src/WebsocketSignatureV4.spec.ts
@@ -58,7 +58,7 @@ describe("WebsocketSignatureV4", () => {
         (isInstance as unknown as jest.Mock).mockReturnValueOnce(true);
       });
 
-      const expectSignArgs = (result: any) => {
+      const expectSignArgs = (result: any, options: RequestPresigningArguments = {}) => {
         expect(result).toStrictEqual({
           ...mockPresignedRequest,
           body: request.body,
@@ -69,6 +69,7 @@ describe("WebsocketSignatureV4", () => {
         expect(presign).toHaveBeenCalledWith(
           { ...request, body: "" },
           {
+            ...options,
             expiresIn: 60,
             unsignableHeaders: new Set(Object.keys(request.headers).filter((header) => header !== "host")),
           }
@@ -82,11 +83,10 @@ describe("WebsocketSignatureV4", () => {
       });
 
       it("with options", async () => {
-        const options = {
-          unsignableHeaders: new Set(Object.keys(headers)),
-        };
+        const signingDate = new Date();
+        const options = { signingDate };
         const result = await sigV4.sign(request as any, options);
-        expectSignArgs(result);
+        expectSignArgs(result, options);
       });
     });
 

diff --git a/packages/middleware-websocket/src/WebsocketSignatureV4.ts b/packages/middleware-websocket/src/WebsocketSignatureV4.ts
@@ -27,6 +27,7 @@ export class WebsocketSignatureV4 implements RequestSigner, RequestPresigner {
       const signedRequest = await this.signer.presign(
         { ...toSign, body: "" },
         {
+          ...options,
           // presigned url must be expired within 1 min.
           expiresIn: 60,
           // Not to sign headers. Transcribe-streaming WebSocket