Skip to content

Commit

Permalink
chore: rename ExponentialBackOff to Standard for RetryStrategy (#1247)
Browse files Browse the repository at this point in the history
  • Loading branch information
trivikr committed Jun 5, 2020
1 parent f3853ab commit 4a6470c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions packages/middleware-retry/src/configurations.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { RetryStrategy } from "@aws-sdk/types";
import { ExponentialBackOffStrategy } from "./defaultStrategy";
import { StandardRetryStrategy } from "./defaultStrategy";

export interface RetryInputConfig {
/**
Expand All @@ -11,18 +11,19 @@ export interface RetryInputConfig {
*/
retryStrategy?: RetryStrategy;
}

export interface RetryResolvedConfig {
maxAttempts: number;
retryStrategy: RetryStrategy;
}

export function resolveRetryConfig<T>(
input: T & RetryInputConfig
): T & RetryResolvedConfig {
const maxAttempts = input.maxAttempts === undefined ? 3 : input.maxAttempts;
return {
...input,
maxAttempts,
retryStrategy:
input.retryStrategy || new ExponentialBackOffStrategy(maxAttempts)
retryStrategy: input.retryStrategy || new StandardRetryStrategy(maxAttempts)
};
}
2 changes: 1 addition & 1 deletion packages/middleware-retry/src/defaultStrategy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface DelayDecider {
(delayBase: number, attempts: number): number;
}

export class ExponentialBackOffStrategy implements RetryStrategy {
export class StandardRetryStrategy implements RetryStrategy {
constructor(
public readonly maxAttempts: number,
private retryDecider: RetryDecider = defaultRetryDecider,
Expand Down
4 changes: 2 additions & 2 deletions packages/middleware-retry/src/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
import { retryMiddleware } from "./retryMiddleware";
import { resolveRetryConfig } from "./configurations";
import * as delayDeciderModule from "./delayDecider";
import { ExponentialBackOffStrategy, RetryDecider } from "./defaultStrategy";
import { StandardRetryStrategy, RetryDecider } from "./defaultStrategy";
import { HttpRequest } from "@aws-sdk/protocol-http";
import { SdkError } from "@aws-sdk/smithy-client";

Expand Down Expand Up @@ -75,7 +75,7 @@ describe("retryMiddleware", () => {
"defaultDelayDecider"
);
const retryDecider: RetryDecider = (error: SdkError) => true;
const strategy = new ExponentialBackOffStrategy(maxAttempts, retryDecider);
const strategy = new StandardRetryStrategy(maxAttempts, retryDecider);
const retryHandler = retryMiddleware({
maxAttempts,
retryStrategy: strategy
Expand Down

0 comments on commit 4a6470c

Please sign in to comment.