-
Notifications
You must be signed in to change notification settings - Fork 556
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(client-s3): remove int validation of object size type
- Loading branch information
1 parent
a3e3927
commit 62dcfc4
Showing
3 changed files
with
86 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
...in/java/software/amazon/smithy/aws/typescript/codegen/AddS3ObjectSizeMemberShapeType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.smithy.aws.typescript.codegen; | ||
|
||
import java.util.Map; | ||
import java.util.Set; | ||
import java.util.logging.Logger; | ||
import software.amazon.smithy.build.PluginContext; | ||
import software.amazon.smithy.model.Model; | ||
import software.amazon.smithy.model.shapes.LongShape; | ||
import software.amazon.smithy.model.shapes.ShapeId; | ||
import software.amazon.smithy.typescript.codegen.TypeScriptSettings; | ||
import software.amazon.smithy.typescript.codegen.integration.TypeScriptIntegration; | ||
import software.amazon.smithy.utils.MapUtils; | ||
import software.amazon.smithy.utils.OptionalUtils; | ||
import software.amazon.smithy.utils.SetUtils; | ||
import software.amazon.smithy.utils.SmithyInternalApi; | ||
|
||
/** | ||
* Transform the S3 object size member from an integer to a long. | ||
*/ | ||
@SmithyInternalApi | ||
public final class AddS3ObjectSizeMemberShapeType implements TypeScriptIntegration { | ||
private static final Logger LOGGER = Logger.getLogger(AddS3ObjectSizeMemberShapeType.class.getName()); | ||
|
||
private static final Map<ShapeId, Set<ShapeId>> SERVICE_TO_SHAPE_MAP = MapUtils.of( | ||
ShapeId.from("com.amazonaws.s3#AmazonS3"), SetUtils.of( | ||
ShapeId.from("com.amazonaws.s3#Size") | ||
) | ||
); | ||
|
||
@Override | ||
public byte getOrder() { | ||
// This integration should happen before other integrations that rely on the presence of this trait | ||
return -60; | ||
} | ||
|
||
@Override | ||
public Model preprocessModel(PluginContext context, TypeScriptSettings settings) { | ||
Model model = context.getModel(); | ||
ShapeId serviceId = settings.getService(); | ||
if (!SERVICE_TO_SHAPE_MAP.containsKey(serviceId)) { | ||
return model; | ||
} | ||
|
||
Set<ShapeId> shapeIds = SERVICE_TO_SHAPE_MAP.get(serviceId); | ||
|
||
Model.Builder builder = model.toBuilder(); | ||
for (ShapeId shapeId : shapeIds) { | ||
OptionalUtils.ifPresentOrElse( | ||
model.getShape(shapeId), | ||
(shape) -> { | ||
if (shape.isLongShape()) { | ||
LOGGER.warning("shape is already modeled as an LONG does not require backfill"); | ||
return; | ||
} | ||
|
||
builder.addShape(LongShape.builder() | ||
.id(shape.getId()) | ||
.addTraits(shape.getAllTraits().values()) | ||
.build()); | ||
}, | ||
() -> LOGGER.warning("shape " + shapeId + " not found in " + serviceId + " model") | ||
); | ||
} | ||
|
||
return builder.build(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters