Skip to content

Commit

Permalink
fix(lib-storage): use correct return type for done() (#5512)
Browse files Browse the repository at this point in the history
  • Loading branch information
nwalters512 committed Nov 28, 2023
1 parent 9d51352 commit 7e1e15e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/lib-storage/src/Upload.ts
@@ -1,5 +1,4 @@
import {
AbortMultipartUploadCommandOutput,
CompletedPart,
CompleteMultipartUploadCommand,
CompleteMultipartUploadCommandOutput,
Expand Down Expand Up @@ -94,7 +93,7 @@ export class Upload extends EventEmitter {
this.abortController.abort();
}

public async done(): Promise<CompleteMultipartUploadCommandOutput | AbortMultipartUploadCommandOutput> {
public async done(): Promise<CompleteMultipartUploadCommandOutput> {
return await Promise.race([this.__doMultipartUpload(), this.__abortTimeout(this.abortController.signal)]);
}

Expand Down Expand Up @@ -360,7 +359,7 @@ export class Upload extends EventEmitter {
}
}

private async __abortTimeout(abortSignal: AbortSignal): Promise<AbortMultipartUploadCommandOutput> {
private async __abortTimeout(abortSignal: AbortSignal): Promise<never> {
return new Promise((resolve, reject) => {
abortSignal.onabort = () => {
const abortError = new Error("Upload aborted.");
Expand Down

0 comments on commit 7e1e15e

Please sign in to comment.