Skip to content

Commit

Permalink
feat(clients): http2 handler accept parameters from default mode prov…
Browse files Browse the repository at this point in the history
…ider (#3580)
  • Loading branch information
AllanZhengYP committed May 9, 2022
1 parent d6b2bdf commit 930c904
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions clients/client-kinesis/src/runtimeConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
NODE_RETRY_MODE_CONFIG_OPTIONS,
} from "@aws-sdk/middleware-retry";
import { loadConfig as loadNodeConfig } from "@aws-sdk/node-config-provider";
import { NodeHttp2Handler, streamCollector } from "@aws-sdk/node-http-handler";
import { NodeHttp2Handler as RequestHandler, streamCollector } from "@aws-sdk/node-http-handler";
import { fromBase64, toBase64 } from "@aws-sdk/util-base64-node";
import { calculateBodyLength } from "@aws-sdk/util-body-length-node";
import { defaultUserAgent } from "@aws-sdk/util-user-agent-node";
Expand Down Expand Up @@ -51,7 +51,7 @@ export const getRuntimeConfig = (config: KinesisClientConfig) => {
eventStreamSerdeProvider: config?.eventStreamSerdeProvider ?? eventStreamSerdeProvider,
maxAttempts: config?.maxAttempts ?? loadNodeConfig(NODE_MAX_ATTEMPT_CONFIG_OPTIONS),
region: config?.region ?? loadNodeConfig(NODE_REGION_CONFIG_OPTIONS, NODE_REGION_CONFIG_FILE_OPTIONS),
requestHandler: config?.requestHandler ?? new NodeHttp2Handler(),
requestHandler: config?.requestHandler ?? new RequestHandler(defaultConfigProvider),
retryMode:
config?.retryMode ??
loadNodeConfig({
Expand Down
4 changes: 2 additions & 2 deletions clients/client-lex-runtime-v2/src/runtimeConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
NODE_RETRY_MODE_CONFIG_OPTIONS,
} from "@aws-sdk/middleware-retry";
import { loadConfig as loadNodeConfig } from "@aws-sdk/node-config-provider";
import { NodeHttp2Handler, streamCollector } from "@aws-sdk/node-http-handler";
import { NodeHttp2Handler as RequestHandler, streamCollector } from "@aws-sdk/node-http-handler";
import { fromBase64, toBase64 } from "@aws-sdk/util-base64-node";
import { calculateBodyLength } from "@aws-sdk/util-body-length-node";
import { defaultUserAgent } from "@aws-sdk/util-user-agent-node";
Expand Down Expand Up @@ -53,7 +53,7 @@ export const getRuntimeConfig = (config: LexRuntimeV2ClientConfig) => {
eventStreamSerdeProvider: config?.eventStreamSerdeProvider ?? eventStreamSerdeProvider,
maxAttempts: config?.maxAttempts ?? loadNodeConfig(NODE_MAX_ATTEMPT_CONFIG_OPTIONS),
region: config?.region ?? loadNodeConfig(NODE_REGION_CONFIG_OPTIONS, NODE_REGION_CONFIG_FILE_OPTIONS),
requestHandler: config?.requestHandler ?? new NodeHttp2Handler(),
requestHandler: config?.requestHandler ?? new RequestHandler(defaultConfigProvider),
retryMode:
config?.retryMode ??
loadNodeConfig({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
case NODE:
return MapUtils.of("requestHandler", writer -> {
writer.addDependency(TypeScriptDependency.AWS_SDK_NODE_HTTP_HANDLER);
writer.addImport("NodeHttp2Handler", "NodeHttp2Handler",
writer.addImport("NodeHttp2Handler", "RequestHandler",
TypeScriptDependency.AWS_SDK_NODE_HTTP_HANDLER.packageName);
writer.write("new NodeHttp2Handler()");
writer.write("new RequestHandler(defaultConfigProvider)");
});
default:
return Collections.emptyMap();
Expand Down

0 comments on commit 930c904

Please sign in to comment.